On 11 April 2016 at 14:31, Heyi Guo <[email protected]> wrote: > Hello, > > Any comments on this patch? >
I think it looks fine. Leif? > On 04/07/2016 09:32 AM, Heyi Guo wrote: >> >> Add macro to help initialize GICD structure in MADT table according to >> ACPI 6.0. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Heyi Guo <[email protected]> >> Cc: Leif Lindholm <[email protected]> >> Cc: Ard Biesheuvel <[email protected]> >> --- >> EmbeddedPkg/Include/Library/AcpiLib.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h >> b/EmbeddedPkg/Include/Library/AcpiLib.h >> index 74a929c..e5bcf56 100644 >> --- a/EmbeddedPkg/Include/Library/AcpiLib.h >> +++ b/EmbeddedPkg/Include/Library/AcpiLib.h >> @@ -38,6 +38,13 @@ >> GicDistHwId, GicDistBase, GicDistVector, EFI_ACPI_RESERVED_DWORD \ >> } >> +#define EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT(GicDistHwId, GicDistBase, >> GicDistVector, GicVersion) \ >> + { \ >> + EFI_ACPI_6_0_GICD, sizeof (EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE), >> EFI_ACPI_RESERVED_WORD, \ >> + GicDistHwId, GicDistBase, GicDistVector, GicVersion, \ >> + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, >> EFI_ACPI_RESERVED_BYTE} \ >> + } >> + >> // Note the parking protocol is configured by UEFI if required >> #define EFI_ACPI_5_0_GIC_STRUCTURE_INIT(GicId, AcpiCpuId, Flags, PmuIrq, >> GicBase) \ >> { \ > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
