Liming,
Some comments below.
On 2016/4/7 14:54, Liming Gao wrote:
Cc: Star Zeng <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <[email protected]>
---
.../Library/VarCheckUefiLib/VarCheckUefiLib.inf | 78 +++++++++++-----------
.../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 10 +--
2 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
index 77ef210..128c44d 100644
--- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
+++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
@@ -45,44 +45,44 @@
VarCheckLib
[Guids]
- ## CONSUMES ## Variable:L"LangCodes"
- ## CONSUMES ## Variable:L"Lang"
- ## CONSUMES ## Variable:L"Timeout"
- ## CONSUMES ## Variable:L"PlatformLangCodes"
- ## CONSUMES ## Variable:L"PlatformLang"
- ## CONSUMES ## Variable:L"ConIn"
- ## CONSUMES ## Variable:L"ConOut"
- ## CONSUMES ## Variable:L"ErrOut"
- ## CONSUMES ## Variable:L"ConInDev"
- ## CONSUMES ## Variable:L"ConOutDev"
- ## CONSUMES ## Variable:L"ErrOutDev"
- ## CONSUMES ## Variable:L"BootOrder"
- ## CONSUMES ## Variable:L"BootNext"
- ## CONSUMES ## Variable:L"BootCurrent"
- ## CONSUMES ## Variable:L"BootOptionSupport"
- ## CONSUMES ## Variable:L"DriverOrder"
- ## CONSUMES ## Variable:L"SysPrepOrder"
- ## CONSUMES ## Variable:L"HwErrRecSupport"
- ## CONSUMES ## Variable:L"SetupMode"
- ## CONSUMES ## Variable:L"PK"
- ## CONSUMES ## Variable:L"KEK"
- ## CONSUMES ## Variable:L"SignatureSupport"
- ## CONSUMES ## Variable:L"SecureBoot"
- ## CONSUMES ## Variable:L"KEKDefault"
- ## CONSUMES ## Variable:L"PKDefault"
- ## CONSUMES ## Variable:L"dbDefault"
- ## CONSUMES ## Variable:L"dbxDefault"
- ## CONSUMES ## Variable:L"dbtDefault"
- ## CONSUMES ## Variable:L"OsIndicationsSupported"
- ## CONSUMES ## Variable:L"OsIndications"
- ## CONSUMES ## Variable:L"VendorKeys"
- ## CONSUMES ## Variable:L"Boot####"
- ## CONSUMES ## Variable:L"Driver####"
- ## CONSUMES ## Variable:L"SysPrep####"
- ## CONSUMES ## Variable:L"Key####"
+ ## SOMETIMES_CONSUMES ## Variable:L"LangCodes"
+ ## SOMETIMES_CONSUMES ## Variable:L"Lang"
+ ## SOMETIMES_CONSUMES ## Variable:L"Timeout"
+ ## SOMETIMES_CONSUMES ## Variable:L"PlatformLangCodes"
+ ## SOMETIMES_CONSUMES ## Variable:L"PlatformLang"
+ ## SOMETIMES_CONSUMES ## Variable:L"ConIn"
+ ## SOMETIMES_CONSUMES ## Variable:L"ConOut"
+ ## SOMETIMES_CONSUMES ## Variable:L"ErrOut"
+ ## SOMETIMES_CONSUMES ## Variable:L"ConInDev"
+ ## SOMETIMES_CONSUMES ## Variable:L"ConOutDev"
+ ## SOMETIMES_CONSUMES ## Variable:L"ErrOutDev"
+ ## SOMETIMES_CONSUMES ## Variable:L"BootOrder"
+ ## SOMETIMES_CONSUMES ## Variable:L"BootNext"
+ ## SOMETIMES_CONSUMES ## Variable:L"BootCurrent"
+ ## SOMETIMES_CONSUMES ## Variable:L"BootOptionSupport"
+ ## SOMETIMES_CONSUMES ## Variable:L"DriverOrder"
+ ## SOMETIMES_CONSUMES ## Variable:L"SysPrepOrder"
+ ## SOMETIMES_CONSUMES ## Variable:L"HwErrRecSupport"
+ ## SOMETIMES_CONSUMES ## Variable:L"SetupMode"
+ ## SOMETIMES_CONSUMES ## Variable:L"PK"
+ ## SOMETIMES_CONSUMES ## Variable:L"KEK"
+ ## SOMETIMES_CONSUMES ## Variable:L"SignatureSupport"
+ ## SOMETIMES_CONSUMES ## Variable:L"SecureBoot"
+ ## SOMETIMES_CONSUMES ## Variable:L"KEKDefault"
+ ## SOMETIMES_CONSUMES ## Variable:L"PKDefault"
+ ## SOMETIMES_CONSUMES ## Variable:L"dbDefault"
+ ## SOMETIMES_CONSUMES ## Variable:L"dbxDefault"
+ ## SOMETIMES_CONSUMES ## Variable:L"dbtDefault"
+ ## SOMETIMES_CONSUMES ## Variable:L"OsIndicationsSupported"
+ ## SOMETIMES_CONSUMES ## Variable:L"OsIndications"
+ ## SOMETIMES_CONSUMES ## Variable:L"VendorKeys"
+ ## SOMETIMES_CONSUMES ## Variable:L"Boot####"
+ ## SOMETIMES_CONSUMES ## Variable:L"Driver####"
+ ## SOMETIMES_CONSUMES ## Variable:L"SysPrep####"
+ ## SOMETIMES_CONSUMES ## Variable:L"Key####"
gEfiGlobalVariableGuid
- ## CONSUMES ## Variable:L"DB"
- ## CONSUMES ## Variable:L"DBX"
- ## CONSUMES ## Variable:L"DBT"
+ ## SOMETIMES_CONSUMES ## Variable:L"DB"
+ ## SOMETIMES_CONSUMES ## Variable:L"DBX"
+ ## SOMETIMES_CONSUMES ## Variable:L"DBT"
gEfiImageSecurityDatabaseGuid
- gEfiHardwareErrorVariableGuid ## CONSUMES ## Variable:L"HwErrRec####"
+ gEfiHardwareErrorVariableGuid ## SOMETIMES_CONSUMES ##
Variable:L"HwErrRec####"
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
index 5e7b5c5..1704b5d 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
@@ -78,8 +78,8 @@
gEdkiiVarCheckProtocolGuid ## PRODUCES
[Guids]
- ## PRODUCES ## GUID # Signature of Variable store header
- ## CONSUMES ## GUID # Signature of Variable store header
+ ## SOMETIMES_CONSUMES ## GUID # Signature of Variable store header
+ ## SOMETIMES_PRODUCES ## GUID # Signature of Variable store header
## SOMETIMES_CONSUMES ## HOB
## SOMETIMES_PRODUCES ## SystemTable
gEfiAuthenticatedVariableGuid
Do not need to do some update for gEfiVariableGuid?
@@ -96,14 +96,14 @@
## SOMETIMES_PRODUCES ## Variable:L"Lang"
gEfiGlobalVariableGuid
- gEfiMemoryOverwriteControlDataGuid ## CONSUMES ##
Variable:L"MemoryOverwriteRequestControl"
- gEfiMemoryOverwriteRequestControlLockGuid ## PRODUCES ##
Variable:L"MemoryOverwriteRequestControlLock"
+ gEfiMemoryOverwriteControlDataGuid ## SOMETIMES_CONSUMES ##
Variable:L"MemoryOverwriteRequestControl"
+ gEfiMemoryOverwriteRequestControlLockGuid ## SOMETIMES_PRODUCES ##
Variable:L"MemoryOverwriteRequestControlLock"
gEfiEventVirtualAddressChangeGuid ## CONSUMES ##
Event
gEfiSystemNvDataFvGuid ## CONSUMES ##
GUID
gEfiEndOfDxeEventGroupGuid ## CONSUMES ##
Event
gEdkiiFaultTolerantWriteGuid ## SOMETIMES_CONSUMES ## HOB
- gEdkiiVarErrorFlagGuid ## CONSUMES ## GUID
+ gEdkiiVarErrorFlagGuid ## SOMETIMES_CONSUMES ## GUID
Could you help update the usage to SOMETIMES_PRODUCES?
## SOMETIMES_CONSUMES ## Variable:L"DB"
## SOMETIMES_CONSUMES ## Variable:L"DBX"
Should the changes to VariableRuntimeDxe.inf not need apply to
VariableSmm.inf also?
Thanks,
Star
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
