Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>
From: Justen, Jordan L Sent: Thursday, April 21, 2016 12:57 AM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [PATCH 00/12] Cleanups to follow FatPkg license update On 2016-04-20 01:29:57, Ni, Ruiyu wrote: > Patch 2 is good. Reviewed-by: Ruiyu Ni > <ruiyu...@intel.com<mailto:ruiyu...@intel.com>> > The commit message for patch 1 looks strange. I cannot fully understand it. > > ----- > The script replaced the contents of License.txt will the words the > shortened text that we include in the headers to files. Instead, use > the full text. This is copied from MdePkg/License.txt. > ---- > > Can you make it more readable? > I sent a reply to patch 1. How about patch 3 for FatBinPkg? Thanks, -Jordan > > >-----Original Message----- > >From: Justen, Jordan L > >Sent: Wednesday, April 20, 2016 4:01 PM > >To: Ni, Ruiyu <ruiyu...@intel.com<mailto:ruiyu...@intel.com>> > >Subject: Fwd: [PATCH 00/12] Cleanups to follow FatPkg license update > > > >web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-cleanups-v1 > > > >git: https://github.com/jljusten/edk2.git fatpkg-open-source-cleanups-v1 > > > >The license update to FatPkg is expected to be pushed later today. > > > >Following the license update, I recommend these changes. > > > >Jordan Justen (12): > > FatPkg: Update License.txt to have the full license text > > FatPkg: Add Contributions.txt > > FatBinPkg: Change to 2-clause BSD license > > ArmVirtPkg: Convert to build FatPkg from source > > BeagleBoardPkg: Convert to build FatPkg from source > > CorebootPayloadPkg: Convert to build FatPkg from source > > DuetPkg scripts: Support building with GCC45 - GCC49 > > DuetPkg: Convert to build FatPkg from source > > EmulatorPkg: Convert to always build FatPkg > > Nt32Pkg: Convert to build FatPkg from source > > OvmfPkg: Convert to using FatPkg in the EDK II tree > > Vlv2TbltDevicePkg: Convert to build FatPkg from source > > > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > > ArmVirtPkg/ArmVirtQemu.fdf | 4 +- > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > > ArmVirtPkg/ArmVirtQemuKernel.fdf | 4 +- > > ArmVirtPkg/ArmVirtXen.dsc | 3 +- > > ArmVirtPkg/ArmVirtXen.fdf | 4 +- > > BeagleBoardPkg/BeagleBoardPkg.dsc | 3 +- > > BeagleBoardPkg/BeagleBoardPkg.fdf | 4 +- > > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 +- > > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 3 +- > > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 +- > > DuetPkg/DuetPkg.fdf | 5 +- > > DuetPkg/DuetPkgIa32.dsc | 3 +- > > DuetPkg/DuetPkgX64.dsc | 3 +- > > DuetPkg/PostBuild.sh | 8 +- > > DuetPkg/build32.sh | 24 ++- > > DuetPkg/build64.sh | 24 ++- > > EmulatorPkg/EmulatorPkg.dsc | 2 - > > EmulatorPkg/EmulatorPkg.fdf | 5 - > > FatBinPkg/FatBinPkg.dec | 2 +- > > FatBinPkg/License.txt | 53 ++---- > > FatPkg/Contributions.txt | 218 > > +++++++++++++++++++++++ > > FatPkg/License.txt | 29 ++- > > Nt32Pkg/Nt32Pkg.dsc | 3 +- > > Nt32Pkg/Nt32Pkg.fdf | 4 +- > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > OvmfPkg/OvmfPkgIa32.fdf | 4 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +- > > OvmfPkg/OvmfPkgIa32X64.fdf | 4 +- > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > OvmfPkg/OvmfPkgX64.fdf | 4 +- > > Vlv2TbltDevicePkg/PlatformPkg.fdf | 7 +- > > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 7 +- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > 36 files changed, 357 insertions(+), 98 deletions(-) > > create mode 100644 FatPkg/Contributions.txt > > > >-- > >2.7.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
