Adding Laszlo & Jordan, It sounds like a trivial bug. Regards, Ray
>-----Original Message----- >From: edk2-devel [mailto:[email protected]] On Behalf Of wang >xiaofeng >Sent: Tuesday, April 26, 2016 3:02 PM >To: Ni, Ruiyu <[email protected]> >Cc: [email protected] >Subject: [edk2] A logic error in OvmfPkg\SataControllerDxe\SataController.c > >Hi All , > I found a logic error in SataControllerStop of > OvmfPkg\SataControllerDxe\SataController.c. > The following code will first free SataPrivateData ,then try to use > SataPrivateData.... > > >if (SataPrivateData != NULL) { > if (SataPrivateData->DisqualifiedModes != NULL) { > FreePool (SataPrivateData->DisqualifiedModes); > } > if (SataPrivateData->IdentifyData != NULL) { > FreePool (SataPrivateData->IdentifyData); > } > if (SataPrivateData->IdentifyValid != NULL) { > FreePool (SataPrivateData->IdentifyValid); > } > FreePool (SataPrivateData); > } > > > // > // Restore original PCI attributes > // > SataPrivateData->PciIo->Attributes ( > SataPrivateData->PciIo, > EfiPciIoAttributeOperationSet, > SataPrivateData->OriginalPciAttributes, > NULL > ); >_______________________________________________ >edk2-devel mailing list >[email protected] >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
