> -----Original Message-----
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, April 28, 2016 7:31 PM
> To: Wu, Hao A; edk2-de...@ml01.01.org; Tian, Feng; samer.el-haj-
> mahm...@hpe.com; Yao, Jiewen
> Cc: Justen, Jordan L
> Subject: Re: [PATCH v3 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe
> driver's adding ASL code
> 
> On 04/28/16 07:08, Hao Wu wrote:
> > The RamDiskDxe driver in MdeModulePkg now will sometimes report a
> NVDIMM
> > Root Device using ASL code which is put in a Secondary System Description
> > Table (SSDT) according to the ACPI 6.1 spec.
> >
> > Locating the SSDT requires modifying the fdf files in OvmfPkg.
> >
> > Cc: Laszlo Ersek <ler...@redhat.com>
> > Cc: Jordan Justen <jordan.l.jus...@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Hao Wu <hao.a...@intel.com>
> > ---
> >  OvmfPkg/OvmfPkgIa32.fdf    | 2 ++
> >  OvmfPkg/OvmfPkgIa32X64.fdf | 2 ++
> >  OvmfPkg/OvmfPkgX64.fdf     | 2 ++
> >  3 files changed, 6 insertions(+)
> >
> > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> > index 93a51a5..287737c 100644
> > --- a/OvmfPkg/OvmfPkgIa32.fdf
> > +++ b/OvmfPkg/OvmfPkgIa32.fdf
> > @@ -444,6 +444,8 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-
> E77F1DB2D792 {
> >      PE32     PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
> >      UI       STRING="$(MODULE_NAME)" Optional
> >      VERSION  STRING="$(INF_VERSION)" Optional
> BUILD_NUM=$(BUILD_NUMBER)
> > +    RAW ACPI  Optional               |.acpi
> > +    RAW ASL   Optional               |.aml
> >    }
> >
> >  [Rule.Common.DXE_RUNTIME_DRIVER]
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> > index aad16a6..cc1587a 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> > @@ -444,6 +444,8 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-
> E77F1DB2D792 {
> >      PE32     PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
> >      UI       STRING="$(MODULE_NAME)" Optional
> >      VERSION  STRING="$(INF_VERSION)" Optional
> BUILD_NUM=$(BUILD_NUMBER)
> > +    RAW ACPI  Optional               |.acpi
> > +    RAW ASL   Optional               |.aml
> >    }
> >
> >  [Rule.Common.DXE_RUNTIME_DRIVER]
> > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> > index 387b808..1b52381 100644
> > --- a/OvmfPkg/OvmfPkgX64.fdf
> > +++ b/OvmfPkg/OvmfPkgX64.fdf
> > @@ -444,6 +444,8 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-
> E77F1DB2D792 {
> >      PE32     PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
> >      UI       STRING="$(MODULE_NAME)" Optional
> >      VERSION  STRING="$(INF_VERSION)" Optional
> BUILD_NUM=$(BUILD_NUMBER)
> > +    RAW ACPI  Optional               |.acpi
> > +    RAW ASL   Optional               |.aml
> >    }
> >
> >  [Rule.Common.DXE_RUNTIME_DRIVER]
> >
> 
> I guess I can ACK this, but what about my other comment, namely setting
> PcdInstallAcpiSdtProtocol to TRUE in the OVMF DSC files?
> 

Sorry for missing the above comment. Yes, I will send out a new version of
patch to set the pcd PcdInstallAcpiSdtProtocol to TRUE in OVMF DSC files.

Best Regards,
Hao Wu

> Thanks,
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to