Reviewed-by: Chao Zhang <chao.b.zh...@intel.com>





Thanks & Best regards
Chao Zhang


-----Original Message-----
From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] 
Sent: Friday, April 29, 2016 4:33 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B; Samer El-Haj-Mahmoud; Samer El-Haj-Mahmoud; Derek Lin
Subject: [PATCH] SecurityPkg: Add DEBUG messages for TPM12Startup

Add DEBUG messages for TPM12Startup to distinguish between TPM_SUCCESS and 
TPM_INVALID_POSTINIT. This helps debugging some hardware problems.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com>
Signed-off-by: Derek Lin <derek.l...@hpe.com>
---
 SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c 
b/SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c
index bc10e45..098dd28 100644
--- a/SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c
+++ b/SecurityPkg/Library/Tpm12CommandLib/Tpm12Startup.c
@@ -2,6 +2,7 @@
   Implement TPM1.2 Startup related command.
 
 Copyright (c) 2013, Intel Corporation. All rights reserved. <BR>
+(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
 This program and the accompanying materials  are licensed and made available 
under the terms and conditions of the BSD License  which accompanies this 
distribution.  The full text of the license may be found at @@ -16,6 +17,7 @@ 
WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/BaseMemoryLib.h>
 #include <Library/BaseLib.h>
 #include <Library/Tpm12DeviceLib.h>
+#include <Library/DebugLib.h>
 
 #pragma pack(1)
 
@@ -59,8 +61,11 @@ Tpm12Startup (
   }
   switch (SwapBytes32(Response.returnCode)) {
   case TPM_SUCCESS:
+    DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_SUCCESS\n"));
+    return EFI_SUCCESS;
   case TPM_INVALID_POSTINIT:
     // In warm reset, TPM may response TPM_INVALID_POSTINIT
+    DEBUG ((DEBUG_INFO, "TPM12Startup: TPM_INVALID_POSTINIT\n"));
     return EFI_SUCCESS;
   default:
     return EFI_DEVICE_ERROR;
--
2.6.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to