Hi Jiewen, It is test with TPM 2.0 part present. There is debug message around each driver loading, which we think should be verbose. The commit description is wrong.
Thanks, Derek -----Original Message----- From: Yao, Jiewen [mailto:[email protected]] Sent: Friday, April 29, 2016 10:38 AM To: Zhang, Chao B <[email protected]>; El-Haj-Mahmoud, Samer <[email protected]>; [email protected] Cc: El-Haj-Mahmoud, Samer <[email protected]>; Lin, Derek (HPS UEFI Dev) <[email protected]>; Yao, Jiewen <[email protected]> Subject: RE: [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe Chao I have question on this patch. I asked in another mail. If there is no TPM 2.0 part present, this code should not run, by design. Would you please clarify how you trigger this situation? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Zhang, Chao B > Sent: Friday, April 29, 2016 10:31 AM > To: Samer El-Haj-Mahmoud <[email protected]>; > [email protected] > Cc: Samer El-Haj-Mahmoud <[email protected]>; Derek Lin > <[email protected]> > Subject: Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in > Tcg2Dxe > > Reviewed-by: Chao Zhang <[email protected]> > > > > > > > Thanks & Best regards > Chao Zhang > > > -----Original Message----- > From: Samer El-Haj-Mahmoud [mailto:[email protected]] > Sent: Friday, April 29, 2016 4:47 AM > To: [email protected] > Cc: Zhang, Chao B; Samer El-Haj-Mahmoud; Samer El-Haj-Mahmoud; Derek > Lin > Subject: [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe > > Reduce several DEBUG messages verbosity from INFO to VERBOSE to reduce > debug spam when there is no TPM 2.0 part present > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> > Signed-off-by: Derek Lin <[email protected]> > --- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > index 07f76af..6555df5 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > @@ -2,6 +2,7 @@ > This module implements Tcg2 Protocol. > > Copyright (c) 2015 - 2016, Intel Corporation. All rights > reserved.<BR> > +(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be > found at @@ -332,14 +333,14 @@ Tcg2GetCapability ( > IN OUT EFI_TCG2_BOOT_SERVICE_CAPABILITY *ProtocolCapability > ) > { > - DEBUG ((EFI_D_INFO, "Tcg2GetCapability ...\n")); > + DEBUG ((DEBUG_VERBOSE, "Tcg2GetCapability ...\n")); > > if ((This == NULL) || (ProtocolCapability == NULL)) { > return EFI_INVALID_PARAMETER; > } > > - DEBUG ((EFI_D_INFO, "Size - 0x%x\n", ProtocolCapability->Size)); > - DEBUG ((EFI_D_INFO, " 1.1 - 0x%x, 1.0 - 0x%x\n", > sizeof(EFI_TCG2_BOOT_SERVICE_CAPABILITY), > sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0))); > + DEBUG ((DEBUG_VERBOSE, "Size - 0x%x\n", ProtocolCapability->Size)); > + DEBUG ((DEBUG_VERBOSE, " 1.1 - 0x%x, 1.0 - 0x%x\n", > + sizeof(EFI_TCG2_BOOT_SERVICE_CAPABILITY), > + sizeof(TREE_BOOT_SERVICE_CAPABILITY_1_0))); > > if (ProtocolCapability->Size < mTcgDxeData.BsCap.Size) { > // > @@ -363,7 +364,7 @@ Tcg2GetCapability ( > } > > CopyMem (ProtocolCapability, &mTcgDxeData.BsCap, > mTcgDxeData.BsCap.Size); > - DEBUG ((EFI_D_INFO, "Tcg2GetCapability - %r\n", EFI_SUCCESS)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2GetCapability - %r\n", EFI_SUCCESS)); > return EFI_SUCCESS; > } > > @@ -1237,7 +1238,7 @@ Tcg2HashLogExtendEvent ( > TCG_PCR_EVENT_HDR NewEventHdr; > TPML_DIGEST_VALUES DigestList; > > - DEBUG ((EFI_D_INFO, "Tcg2HashLogExtendEvent ...\n")); > + DEBUG ((DEBUG_VERBOSE, "Tcg2HashLogExtendEvent ...\n")); > > if ((This == NULL) || (DataToHash == 0) || (Event == NULL)) { > return EFI_INVALID_PARAMETER; > @@ -1287,7 +1288,7 @@ Tcg2HashLogExtendEvent ( > Event->Event > ); > } > - DEBUG ((EFI_D_INFO, "Tcg2HashLogExtendEvent - %r\n", Status)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2HashLogExtendEvent - %r\n", Status)); > return Status; > } > > @@ -2530,10 +2531,10 @@ DriverEntry ( > mTcgDxeData.BsCap.SupportedEventLogs &= > ~EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2; > } > > - DEBUG ((EFI_D_INFO, "Tcg2.SupportedEventLogs - 0x%08x\n", > mTcgDxeData.BsCap.SupportedEventLogs)); > - DEBUG ((EFI_D_INFO, "Tcg2.HashAlgorithmBitmap - 0x%08x\n", > mTcgDxeData.BsCap.HashAlgorithmBitmap)); > - DEBUG ((EFI_D_INFO, "Tcg2.NumberOfPCRBanks - 0x%08x\n", > mTcgDxeData.BsCap.NumberOfPCRBanks)); > - DEBUG ((EFI_D_INFO, "Tcg2.ActivePcrBanks - 0x%08x\n", > mTcgDxeData.BsCap.ActivePcrBanks)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2.SupportedEventLogs - 0x%08x\n", > + mTcgDxeData.BsCap.SupportedEventLogs)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2.HashAlgorithmBitmap - 0x%08x\n", > mTcgDxeData.BsCap.HashAlgorithmBitmap)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2.NumberOfPCRBanks - > 0x%08x\n", mTcgDxeData.BsCap.NumberOfPCRBanks)); > + DEBUG ((DEBUG_VERBOSE, "Tcg2.ActivePcrBanks - 0x%08x\n", > mTcgDxeData.BsCap.ActivePcrBanks)); > > if (mTcgDxeData.BsCap.TPMPresentFlag) { > // > -- > 2.6.3.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
