On 04/29/16 09:01, Ruiyu Ni wrote:
> By default the new MdeModulePkg/BDS is used.
> If USE_OLD_BDS is defined to TRUE, IntelFrameworkModulePkg/BDS
> is used.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> ---
>  OvmfPkg/OvmfPkgIa32.dsc    | 41 +++++++++++++++++++++++++++++++++++++----
>  OvmfPkg/OvmfPkgIa32.fdf    |  5 +++++
>  OvmfPkg/OvmfPkgIa32X64.dsc | 41 +++++++++++++++++++++++++++++++++++++----
>  OvmfPkg/OvmfPkgIa32X64.fdf |  5 +++++
>  OvmfPkg/OvmfPkgX64.dsc     | 41 +++++++++++++++++++++++++++++++++++++----
>  OvmfPkg/OvmfPkgX64.fdf     |  5 +++++
>  6 files changed, 126 insertions(+), 12 deletions(-)

This patch is almost done, but you missed one of the un-indentations
that I asked for in v3.

Only the "OvmfPkgIa32.dsc" file is affected:

> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc

> @@ -551,13 +566,32 @@ [Components]
>    PcAtChipsetPkg/KbcResetDxe/Reset.inf
>    MdeModulePkg/Universal/Metronome/Metronome.inf
>    PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
> +!if $(USE_OLD_BDS) == TRUE
>    IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
>      <LibraryClasses>
> +  !ifdef $(CSM_ENABLE)

This !ifdef directive (and its matching !endif).

With these directives un-indented:

Reviewed-by: Laszlo Ersek <ler...@redhat.com>

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to