Thanks! > -----Original Message----- > From: Zeng, Star > Sent: Monday, May 02, 2016 9:39 PM > To: Carsey, Jaben <[email protected]>; Cinnamon Shia > <[email protected]>; [email protected] > Cc: Qiu, Shumin <[email protected]>; [email protected] > Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer > library instance error!" > Importance: High > > Pushed at 69af847603ca1f6439031c4e1fee844fdb06ca6f and > 0cd1e699e5f76b3323b5881932af8a62bc5edf2a. > > Thanks, > Star > -----Original Message----- > From: Carsey, Jaben > Sent: Monday, May 2, 2016 11:33 PM > To: Zeng, Star <[email protected]>; Cinnamon Shia > <[email protected]>; [email protected] > Cc: Qiu, Shumin <[email protected]>; [email protected]; > Carsey, Jaben <[email protected]> > Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer > library instance error!" > > Reviewed-by: Jaben Carsey <[email protected]> > > > -----Original Message----- > > From: Zeng, Star > > Sent: Monday, May 02, 2016 1:25 AM > > To: Cinnamon Shia <[email protected]>; [email protected] > > Cc: Qiu, Shumin <[email protected]>; Carsey, Jaben > > <[email protected]>; [email protected] > > Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message > > "Timer library instance error!" > > Importance: High > > > > Reviewed-by: Star Zeng <[email protected]> to series. > > > > Thanks, > > Star > > -----Original Message----- > > From: Cinnamon Shia [mailto:[email protected]] > > Sent: Monday, May 2, 2016 12:34 PM > > To: [email protected] > > Cc: Qiu, Shumin <[email protected]>; Zeng, Star > > <[email protected]>; Carsey, Jaben <[email protected]>; > > [email protected]; Cinnamon Shia > <[email protected]> > > Subject: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message > > "Timer library instance error!" > > > > When executing shell dp command, there is an error message "Timer > > library instance error!" > > > > The error message "Timer library instance error!" should be for the > > case about duration > EndTimeStamp if CountUp or duration > > > StartTimeStamp if CountDown. > > > > But if the EndTimeStamp of an entry is not added, it should not the > > case to catch. > > > > This change fixes the error message "Timer library instance error!" > > from the "BdsAttempt" entry which is logged when trying to boot a boot > option. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Cinnamon Shia <[email protected]> > > --- > > ShellPkg/Library/UefiDpLib/DpUtilities.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiDpLib/DpUtilities.c > > b/ShellPkg/Library/UefiDpLib/DpUtilities.c > > index 032e7b4..fbdd938 100644 > > --- a/ShellPkg/Library/UefiDpLib/DpUtilities.c > > +++ b/ShellPkg/Library/UefiDpLib/DpUtilities.c > > @@ -2,7 +2,7 @@ > > Utility functions used by the Dp application. > > > > Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved. > > - (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > > + (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > + LP<BR> > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of > > the BSD License > > which accompanies this distribution. The full text of the license > > may be found at @@ -68,6 +68,10 @@ GetDuration ( > > UINT64 Duration; > > BOOLEAN Error; > > > > + if (Measurement->EndTimeStamp == 0) { > > + return 0; > > + } > > + > > // PERF_START macros are called with a value of 1 to indicate > > // the beginning of time. So, adjust the start ticker value > > // to the real beginning of time. > > -- > > 2.8.1.windows.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
