Liming, Responses below.
Mike > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, May 3, 2016 10:43 PM > To: Kinney, Michael D <[email protected]>; [email protected]; > Kinney, > Michael D <[email protected]> > Cc: Wu, Mike <[email protected]> > Subject: RE: [RFC] EDK2 Platforms Proposal > > Mike: > I have some comments. > 1) If the platforms wants to base on edk2 master, it is not suggested to be > placed into > edk2-platform repo. Right? No. A platform can still be based on edk2/master and be in edk2-platforms. Edk2-platforms is a fork of edk2, so edk2-platforms/master can track edk2/master and any branch in edk2-platforms can choose to sync to edk2/master. > 2) On add a new platform to edk2-platforms, who approves the request? Edk2 > maintainer? > Now, edk2 maintainer are edk2 package owner. So, for new platform, their > owner will > become edk2 maintainer. Just like edk2-staging, a platform branch in edk2-staging requires one or more maintainer(s) With write access to create and maintain the branch. If a developer for a platform port is not a maintainer, they can do their work in a developer owned github fork or find a maintainer to help add platform to edk2-platforms. > 3) On update source in edk2-platform branch, the change in core package is > allowed? For > example, Platform feature may detect core issue, and this issue is not fixed > in edk2 > master. Could platform owners add their fix first or they need wait for the > formal fix > in edk2 master, then sync the fix to their branch? Just like edk2-staging, each branch owner gets to decide how to manage their branch. If A temp change is required in a package from edk2/master, then they could be done in the platform branch and later considered for an edk2 package change or removal of temp fix if a better solution is found. Platforms are recommended to use edk2/master or a stable release of edk2. > 3) On remove an edk2-platforms branch, I think we need to collect the > feedback from the > platform owner. I agree. That is in the process step 7b to send email to edk2-devel. > > Thanks > Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Kinney, Michael > D > Sent: Wednesday, May 4, 2016 12:31 AM > To: [email protected]; Kinney, Michael D <[email protected]> > Subject: [edk2] [RFC] EDK2 Platforms Proposal > > Hello, > > > > Similar to edk2-staging, we also have a need to manage platforms that have > been > > ported to edk2. Jordan has created a repository called edk2-platforms and > > has created a branch for the minnowboard-max that uses a validated release > > of the UDK 2015 for the dependent packages: > > > > https://github.com/tianocore/edk2-platforms > > > > https://github.com/tianocore/edk2-platforms/tree/minnowboard-max-udk2015 > > > > > > Instead of creating a branch per feature in edk2-staging, the proposal is to > > create a branch per platform in edk2-platforms. The maintainer(s) that create > > and support a platform branch can decide if the platform is synced to > edk2/master > > for dependent packages, or uses a stable release of the edk2 for dependent > packages. > > > > This proposal provides an area for platform development so we can minimize the > > number of platforms that are included in edk2/master. It is important to keep > > some platforms in edk2/master so we can use those platforms to validate > features > > in non-platform packages in edk2/master. If a new platform does not add > feature > > coverage to edk2/master, then a new edk2-platforms branch would be > recommended. > > > > Please review the proposal below for edk2-platforms. > > > > If this proposal is accepted, then a review of the platform in edk2/master can > > Be done to see if any of them should be moved to branches in edk2-platforms. > > > > <proposal> > > > > Problem statement > > ================= > > Need place on tianocore.org where platforms can be maintained by the EDK II > > community. This serves several purposes: > > > > * Encourage more platforms sources to be shared earlier in the development > process > > * Allow platform sources to be shared that may not yet meet all edk2 required > quality > criteria > > * Allow platform source to be shared so the EDK II community may choose to > help finish > and validate > > * Allow more platforms to be used as part of the edk2 validation and release > cycle. > > * Not intended to be used for bug fixes. > > > > Proposal > > ======== > > 1) Create a new repo called edk2-platforms > > a) edk2-platforms is a fork of edk2 > > b) edk2-platforms/master tracks edk2/master > > > > 2) edk2-platforms discussions can use the existing edk2-devel mailing list for > design/patch/test. > > Use the following style for discussion of a platform branch in > edk2-platforms > repo. > > > > [platforms/branch]: Subject > > > > 3) All commits to edk2-platforms must follow same edk2 rules (e.g. Tiano > Contributor's > Agreement) > > > > 4) Process to add a new platform to edk2-platforms > > a) Maintainer sends patch email to edk2-devel mailing list announcing > the creation > of a new > > platform branch in edk2-platforms with Readme.MD. Readme.MD is in > root of > platform branch > > with summary, owners, status, build instructions, target update > instructions, > OS compatibility, > > known issues/limitations, links to related materials, and anything > else a > developer would need > > to use the platform branch. > > b) Maintainer creates platform branch in edk2-platforms > > c) Maintainer is responsible syncing platform to edk2/master or > supported edk2 > branch. > > > > 5) Process to update sources in feature branch > > a) Commit message subject format: > > > > [platforms/branch PATCH]: Package/Module: Subject > > > > b) Directly commit changes to platform branch or if community review is > desired, > > then use edk2-devel review process. > > > > 7) Process to remove an edk2-platforms branch > > a) Stewards may periodically review of platform branches in > edk2-platforms (once a > quarter?) > > b) If no activity for extended period of time and platform is not being > maintained > and is no > > longer functional then stewards send email to edk2-devel to request > deletion of > platform > > branch. > > c) If no objections from EDK II community, then platform branch is > deleted and > archived at > > https://github.com/tianocore/edk2-archive. > > > > 8) How to evaluate a platform in edk2-platforms > > a) Clone edk2-platforms/[branch name] > > b) Following instructions in Readme.MD to build firmware and update > target > platform > > > > </proposal> > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
