The series is good to me. Reviewed-by: Hao Wu <[email protected]>
Best Regards, Hao Wu > -----Original Message----- > From: Tian, Feng > Sent: Wednesday, May 04, 2016 1:12 PM > To: Wu, Hao A > Cc: [email protected] > Subject: [patch 0/5] fixes several issues in EDKII SD stack > > The fixed issues include: > 1. break cmd exec earlier if the card isn't identified successfully > 2. Use BaseClk if the target clock is larger than BaseClk > 3. Use PIO rather DMA mode for sample clock tuning to strictly > follow SD HC spec. > 4. Enhance error handling of tuning procedure > 5. Check supported bus mode before switch > > Feng Tian (5): > MdeModulePkg/SdMmcPciHcDxe: break cmd exec if the card isn't > identified > MdeModulePkg/SdMmcPciHcDxe: Use BaseClk if the target clock is larger > MdeModulePkg/SdMmcPciHcDxe: Using PIO rather than DMA for clock tuning > MdeModulePkg/SdMmcPciHcDxe: Error handling enhance on tuning > procedure > MdeModulePkg/SdMmcPciHcDxe: Check SD's supported bus mode before > switch > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 22 +++- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 73 +++++++---- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 33 ++++- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 1 + > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 127 ++++++++++- > ------- > MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 96 ++++++++++---- > MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 146 ++++++++++++++----- > -- > MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.h | 14 +- > 8 files changed, 344 insertions(+), 168 deletions(-) > > -- > 2.7.1.windows.2 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel

