On 05/06/16 17:41, El-Haj-Mahmoud, Samer wrote: > What is the status of this series? It got reviewed a while ago,
Where? I can only find my own review for v4 2/2, and your review for v4 0/2. But, patch #1 doesn't even seem to be part of the v4 posting (!), plus I can't find reviews from MdeModulePkg maintainers for patch #1. Thanks Laszlo > but it still not committed. > > From: El-Haj-Mahmoud, Samer > Sent: Thursday, April 28, 2016 10:30 PM > To: [email protected]; [email protected]; [email protected]; > [email protected] > Cc: [email protected] > Subject: RE: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM > disks > > Series Reviewed-By: Samer El-Haj-Mahmoud <[email protected]<mailto:[email protected]>> > > > > -----Original Message----- > From: Hao Wu [[email protected]] > Received: Thursday, 28 Apr 2016, 9:23PM > To: [email protected]<mailto:[email protected]> > [[email protected]]; [email protected]<mailto:[email protected]> > [[email protected]]; > [email protected]<mailto:[email protected]> > [[email protected]] > CC: Hao Wu [[email protected]] > Subject: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks > Since the RamDiskDxe part in MdeModulePkg has not been changed, this > series only contains the patch for changes made in OvmfPkg. > > Changes compared with V3: > 1. Set Pcd 'PcdInstallAcpiSdtProtocol' to TURE in OVMF DSC files. > > Changes compared with V2: > 1. RamDiskDxe driver now will register an EFI event in the Ready To Boot > Event Group to a). detect whether EFI_ACPI_TABLE_PROTOCOL and > EFI_ACPI_SDT_PROTOCOL are both produced; b). publish all the reserved > memory type RAM disks registered at this point to the NFIT if both > protocols are produced. > > 2. The RamDiskUnpublishNfit() now will uninstall NFIT and SSDT that is > used to report the NVDIMM root device from the ACPI table when there is > no NFIT structure in NFIT after removing a RAM disk. > > 3. Instead of adding a new rule in OvmfPkg FDF files, the patch now lists > the asl and aml options in the main [Rule.Common.DXE_DRIVER] field. > > > Changes compared with V1: > 1. Instead of creating a new NFIT for each registered reserved memory RAM > disk, new cotent of the NFIT is appended to the existing one. > > 2. Report an NVDIMM root device in the \SB scope if there is no NFIT in > the ACPI table. > > 3. Modify FDF files in OvmfPkg to make sure the report of the NVDIMM root > device will be done correctly. > > > Hao Wu (2): > MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM > disks > OvmfPkg: Modify FDF/DSC files for RamDiskDxe's adding NFIT report > feature > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDisk.asl | 44 ++ > .../Universal/Disk/RamDiskDxe/RamDiskDriver.c | 80 ++++ > .../Universal/Disk/RamDiskDxe/RamDiskDxe.inf | 12 + > .../Universal/Disk/RamDiskDxe/RamDiskImpl.h | 28 ++ > .../Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 494 > +++++++++++++++++++++ > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32.fdf | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.fdf | 2 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 2 + > 11 files changed, 667 insertions(+) > create mode 100644 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDisk.asl > > -- > 1.9.5.msysgit.0 > > _______________________________________________ > edk2-devel mailing list > [email protected]<mailto:[email protected]> > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
