On 6 May 2016 at 19:19, Mark Rutland <[email protected]> wrote: > The LAN9118 driver uses memory fences in a novel but erroneous fashion, due to > a misunderstanding of some under-commented code. This series fixes these > erroneous uses, documenting the unusual requirements of the LAN9118 chip that > lead us to this situation, and introduces new helpers to handle this in a more > consistent fashion. > > The LAN9118 datasheet is publicly available at: > > http://www.microchip.com/wwwproducts/en/LAN9118 >
Thanks a lot for getting to the bottom of this! I particularly like the way how you folded the required delays into the MMIO read/write functions, which makes the top level code a lot cleaner. I can't test this, but the code looks fine to me. Reviewed-by: Ard Biesheuvel <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
