On 05/09/16 08:26, Ruiyu Ni wrote:
> Contributed-under: TianoCore contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <[email protected]>
> Cc: Laszlo Ersek <[email protected]>
> ---
>  OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c 
> b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> index 1d3d10a..9e01498 100644
> --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> @@ -125,11 +125,11 @@ InitRootBridge (
>    RootBus->DmaAbove4G = FALSE;
>  
>    RootBus->AllocationAttributes = EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM;
> -  RootBus->PMem.Base            = 0;
> +  RootBus->PMem.Base            = MAX_UINT64;
>    RootBus->PMem.Limit           = 0;
> -  RootBus->PMemAbove4G.Base     = 0;
> +  RootBus->PMemAbove4G.Base     = MAX_UINT64;
>    RootBus->PMemAbove4G.Limit    = 0;
> -  RootBus->MemAbove4G.Base      = 0;
> +  RootBus->MemAbove4G.Base      = MAX_UINT64;
>    RootBus->MemAbove4G.Limit     = 0;
>  
>    if (PcdGet64 (PcdPciMmio64Size) > 0) {
> 

Please add the following to the commit message:

--------
In order to match the previous commit, Base must be strictly larger than
Limit if some type of aperture is not available on a PCI root bridge.
--------

With the above:

Reviewed-by: Laszlo Ersek <[email protected]>

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to