Reviewed-by: Samer El-Haj-Mahmoud <[email protected]>

-----Original Message-----
From: Jiaxin Wu [mailto:[email protected]] 
Sent: Sunday, May 8, 2016 9:51 PM
To: [email protected]
Cc: El-Haj-Mahmoud, Samer <[email protected]>; Ye Ting 
<[email protected]>; Fu Siyuan <[email protected]>
Subject: [staging/HTTPS-TLS][PATCH] NetworkPkg: Fix unclosed TCP connection 
case if TLS session failed

This patch is used to fix unclosed TCP connection case if TLS session build 
failed.

Cc: El-Haj-Mahmoud Samer <[email protected]>
Cc: Ye Ting <[email protected]>
Cc: Fu Siyuan <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <[email protected]>
---
 NetworkPkg/HttpDxe/HttpImpl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c 
index cf58b13..d380d6a 100644
--- a/NetworkPkg/HttpDxe/HttpImpl.c
+++ b/NetworkPkg/HttpDxe/HttpImpl.c
@@ -594,14 +594,14 @@ Error4:
 Error3:
   if (HttpInstance->UseHttps) {
     TlsCloseSession (HttpInstance);
     TlsCloseTxRxEvent (HttpInstance);
   }
-
-  HttpCloseConnection (HttpInstance);
 
 Error2:
+  HttpCloseConnection (HttpInstance);
+  
   HttpCloseTcpConnCloseEvent (HttpInstance);
   if (NULL != Wrap->TcpWrap.Tx4Token.CompletionToken.Event) {
     gBS->CloseEvent (Wrap->TcpWrap.Tx4Token.CompletionToken.Event);
     Wrap->TcpWrap.Tx4Token.CompletionToken.Event = NULL;
   }
--
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to