On 11 May 2016 at 13:57, Ard Biesheuvel <[email protected]> wrote:
> On 11 May 2016 at 14:54, Laszlo Ersek <[email protected]> wrote:
>> On 05/11/16 14:47, Ard Biesheuvel wrote:
>>> This implements the platform glue for the new generic BDS implementation.
>>> It is based on the ArmVirtQemu version, with the QEMU references removed.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Ard Biesheuvel <[email protected]>
>>> ---
>>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c               | 562 
>>> ++++++++++++++++
>>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h               |  59 ++
>>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |  86 +++
>>>  ArmPkg/Library/PlatformBootManagerLib/QuietBoot.c                | 680 
>>> ++++++++++++++++++++
>>>  4 files changed, 1387 insertions(+)
>>
>>> +  //~ Status = gRT->GetVariable (L"Timeout",
>>> +                  //~ &gEfiGlobalVariableGuid,
>>> +                  //~ NULL,
>>> +                  //~ sizeof (Timeout),
>>> +                  //~ &Timeout);
>>> +  //~ if (!EFI_ERROR (Status)) {
>>> +    //~ PcdSet16 (PcdPlatformBootTimeOut, Timeout);
>>> +  //~ }
>>
>> Forgotten or intentional?
>>
>
> Forgotten.
>
> I discovered that this
>
> [PcdsDynamicExHii.common.DEFAULT]
>   
> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5
>
> does the trick nicely.
>
> Thanks for spotting that.

Provided you clean that up on commit:
Reviewed-by: Leif Lindholm <[email protected]>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to