On 12 May 2016 at 14:32, Laszlo Ersek <[email protected]> wrote:
> On 05/12/16 11:06, Ard Biesheuvel wrote:
>> This implements the platform glue for the new generic BDS implementation.
>> It is based on the ArmVirtQemu version, with the QEMU references removed.
>>
>> During the timeout, the following message is printed, with an additional
>> trailing period added for every second waited.
>>
>>   Press ESCAPE for boot options ..
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <[email protected]>
>> ---
>> v2:
>> - remove stale commented out code
>> - added timeout message
>>
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c               | 554 
>> ++++++++++++++++
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h               |  59 ++
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |  85 +++
>>  ArmPkg/Library/PlatformBootManagerLib/QuietBoot.c                | 680 
>> ++++++++++++++++++++
>>  4 files changed, 1378 insertions(+)
>
> Can you also mention in the commit message (if you haven't pushed the
> patch yet) that PcdDefaultTerminalType is required to be TtyTerm,
> unconditionally?
>

Good point. Thanks for spotting that. Unfortunately, I just pushed it
a minute ago

> Reviewed-by: Laszlo Ersek <[email protected]>
>

Thanks!
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to