Jordan, Yes. I noticed that when git was in the sending the emails mode and it complained.
I am sending V3 now. Mike > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, May 12, 2016 3:57 PM > To: Kinney, Michael D <[email protected]>; [email protected] > Cc: Leahy, Leroy P <[email protected]> > Subject: Re: [edk2] [Patch v2 1/3] QuarkPlatformPkg: Fix build errors > > On 2016-05-12 15:36:06, Michael Kinney wrote: > > From: "Leahy, Leroy P" </O=Intel/OU=Americas01/cn=Recipients/cn=lpleahy> > > Can you fix the author on these patches? > > git commit --amend --author="Lee Leahy <[email protected]>" > > Maybe Lee needs to fix his user.name and user.email settings? > > -Jordan > > > > > Fix build errors detected with GCC 4.8.4: local variable set but not > > used! > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Lee Leahy <[email protected]> > > Reviewed-by: Michael Kinney <[email protected]> > > --- > > QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c | 4 +--- > > QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c | 6 > > +----- > > .../Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c | 6 > > ++---- > > .../Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c | 5 +---- > > .../Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c | 5 +---- > > QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c | 8 > > +------- > > QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c | 5 +---- > > 7 files changed, 8 insertions(+), 31 deletions(-) > > > > diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > > index b0f0b44..96af046 100644 > > --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > > +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > > @@ -1,7 +1,7 @@ > > /** @file > > Update the _PRT and _PRW method for pci devices > > > > -Copyright (c) 2013-2015 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -261,9 +261,7 @@ SdtGetNameStringSize ( > > { > > UINTN SegCount; > > UINTN Length; > > - UINT8 *Name; > > > > - Name = Buffer; > > Length = 0; > > > > // > > diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > > index aa18cae..309eb04 100644 > > --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > > +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > > @@ -1,7 +1,7 @@ > > /** @file > > ACPI Platform Driver > > > > -Copyright (c) 2013-2015 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -255,7 +255,6 @@ ApicTableUpdate ( > > UINT8 CurrProcessor; > > UINTN NumberOfCPUs; > > UINTN NumberOfEnabledCPUs; > > - UINTN BufferSize; > > EFI_PROCESSOR_INFORMATION MpContext; > > ACPI_APIC_STRUCTURE_PTR *ApicPtr; > > > > @@ -298,7 +297,6 @@ ApicTableUpdate ( > > switch (ApicPtr->AcpiApicCommon.Type) { > > > > case EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC: > > - BufferSize = sizeof (EFI_PROCESSOR_INFORMATION); > > ApicPtr->AcpiLocalApic.Flags = 0; > > ApicPtr->AcpiLocalApic.ApicId = 0; > > Status = MpService->GetProcessorInfo ( > > @@ -562,7 +560,6 @@ AcpiPlatformEntryPoint ( > > UINT32 FvStatus; > > UINTN Size; > > EFI_ACPI_TABLE_VERSION Version; > > - QNC_DEVICE_ENABLES QNCDeviceEnables; > > EFI_HANDLE Handle; > > UINTN Index; > > PCI_DEVICE_INFO *PciDeviceInfo; > > @@ -577,7 +574,6 @@ AcpiPlatformEntryPoint ( > > TableHandle = 0; > > CurrentTable = NULL; > > mConfigData = NULL; > > - QNCDeviceEnables.Uint32 = PcdGet32 (PcdDeviceEnables); > > > > // > > // Initialize the EFI Driver Library > > diff --git > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > > index d17f5ea..322d7ce 100644 > > --- > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > > +++ > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > > @@ -2,7 +2,7 @@ > > This driver parses the mSmbiosMiscDataTable structure and reports > > any generated data. > > > > -Copyright (c) 2013-2015 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -190,7 +190,6 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages) > > CHAR8 > > CurrentLang[SMBIOS_STRING_MAX_LENGTH + > 1]; > > CHAR8 *OptionalStrStart; > > UINT16 Offset; > > - BOOLEAN LangMatch; > > EFI_STATUS Status; > > EFI_SMBIOS_HANDLE SmbiosHandle; > > SMBIOS_TABLE_TYPE13 *SmbiosRecord; > > @@ -210,9 +209,8 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages) > > // > > // Try to check if current langcode matches with the langcodes in > > installed > languages > > // > > - LangMatch = FALSE; > > ZeroMem(CurrentLang, SMBIOS_STRING_MAX_LENGTH + 1); > > - LangMatch = CurrentLanguageMatch (mHiiHandle, &Offset, CurrentLang); > > + CurrentLanguageMatch (mHiiHandle, &Offset, CurrentLang); > > LangStrLen = AsciiStrLen(CurrentLang); > > > > // > > diff --git > > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > > index e352000..f5b2162 100644 > > --- a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > > +++ b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > > @@ -2,7 +2,7 @@ > > boot information boot time changes. > > SMBIOS type 11. > > > > -Copyright (c) 2013-2015 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -38,9 +38,6 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscOemString) > > STRING_REF TokenToGet; > > EFI_SMBIOS_HANDLE SmbiosHandle; > > SMBIOS_TABLE_TYPE11 *SmbiosRecord; > > - EFI_MISC_OEM_STRING *ForType11InputData; > > - > > - ForType11InputData = (EFI_MISC_OEM_STRING *)RecordData; > > > > // > > // First check for invalid parameters. > > diff --git > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > > index 44cc684..f12a2e4 100644 > > --- > > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > > +++ > > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > > @@ -2,7 +2,7 @@ > > BIOS system option string boot time changes. > > SMBIOS type 12. > > > > -Copyright (c) 2013-2015 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -40,9 +40,6 @@ MISC_SMBIOS_TABLE_FUNCTION(SystemOptionString) > > STRING_REF TokenToGet; > > EFI_SMBIOS_HANDLE SmbiosHandle; > > SMBIOS_TABLE_TYPE12 *SmbiosRecord; > > - EFI_MISC_SYSTEM_OPTION_STRING *ForType12InputData; > > - > > - ForType12InputData = (EFI_MISC_SYSTEM_OPTION_STRING *)RecordData; > > > > // > > // First check for invalid parameters. > > diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > > index ea67ba9..fd7a937 100644 > > --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > > +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > > @@ -2,7 +2,7 @@ > > Install Platform EFI_PEI_RECOVERY_MODULE_PPI and Implementation of > > EFI_PEI_LOAD_RECOVERY_CAPSULE service. > > > > -Copyright (c) 2013 Intel Corporation. > > +Copyright (c) 2013-2016 Intel Corporation. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the BSD > > License > > @@ -137,26 +137,21 @@ Returns: > > UINTN NumberRecoveryCapsules; > > UINTN RecoveryCapsuleSize; > > EFI_GUID DeviceId; > > - BOOLEAN ImageFound; > > EFI_PHYSICAL_ADDRESS Address; > > VOID *Buffer; > > EFI_CAPSULE_HEADER *CapsuleHeader; > > EFI_PEI_HOB_POINTERS Hob; > > - EFI_PEI_HOB_POINTERS HobOld; > > BOOLEAN HobUpdate; > > EFI_FIRMWARE_VOLUME_HEADER *FvHeader; > > UINTN Index; > > - EFI_STATUS AuthStatus; > > EFI_GUID mEfiCapsuleHeaderGuid = > QUARK_CAPSULE_GUID; > > > > Index = 0; > > > > Status = EFI_SUCCESS; > > - AuthStatus = EFI_SUCCESS; > > HobUpdate = FALSE; > > > > ProviderAvailable = TRUE; > > - ImageFound = FALSE; > > NumberOfImageProviders = 0; > > > > DeviceRecoveryModule = NULL; > > @@ -284,7 +279,6 @@ Returns: > > // > > Buffer = (VOID *)((UINT8 *) Buffer); > > Status = PeiServicesGetHobList ((VOID **)&Hob.Raw); > > - HobOld.Raw = Hob.Raw; > > while (!END_OF_HOB_LIST (Hob)) { > > if (Hob.Header->HobType == EFI_HOB_TYPE_FV) { > > DEBUG ((EFI_D_INFO | EFI_D_LOAD, "Hob FV Length: %x\n", > Hob.FirmwareVolume->Length)); > > diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > b/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > > index 70c9cf9..df6c1cc 100644 > > --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > > +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > > @@ -1089,7 +1089,6 @@ RetriveRequiredMemorySize ( > > OUT UINTN *Size > > ) > > { > > - EFI_STATUS Status; > > EFI_PEI_HOB_POINTERS Hob; > > EFI_MEMORY_TYPE_INFORMATION *MemoryData; > > UINT8 Index; > > @@ -1099,7 +1098,7 @@ RetriveRequiredMemorySize ( > > TempPageNum = 0; > > Index = 0; > > > > - Status = PeiServicesGetHobList ((VOID **)&Hob.Raw); > > + PeiServicesGetHobList ((VOID **)&Hob.Raw); > > while (!END_OF_HOB_LIST (Hob)) { > > if (Hob.Header->HobType == EFI_HOB_TYPE_GUID_EXTENSION && > > CompareGuid (&Hob.Guid->Name, &gEfiMemoryTypeInformationGuid) > > @@ -1171,7 +1170,6 @@ GetMemoryMap ( > > PEI_MEMORY_RANGE_SMRAM SmramMask; > > PEI_MEMORY_RANGE_SMRAM TsegMask; > > UINT32 BlockNum; > > - UINT8 EsmramcRegister; > > UINT8 ExtendedMemoryIndex; > > UINT32 Register; > > > > @@ -1194,7 +1192,6 @@ GetMemoryMap ( > > // > > // Generate Memory ranges for the memory map. > > // > > - EsmramcRegister = 0; > > MemorySize = 0; > > > > RowLength = TotalMemorySize; > > -- > > 2.6.3.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
