Reviewed-by: Liming Gao <liming....@intel.com>
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, May 13, 2016 11:24 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming....@intel.com>; > wang xiaofeng <winggundu...@163.com> > Subject: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Fix a logic error > > From: wang xiaofeng <winggundu...@163.com> > > if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & > EnableMask) != EnableMask)) { > > The bracket place is not right, I think it should be > > if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & > EnableMask) != EnableMask) > > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: wang xiaofeng <winggundu...@163.com> > Reviewed-by: Star Zeng <star.z...@intel.com> > --- > PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c > b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c > index ad855fe4f517..806a4f7ce24c 100644 > --- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c > +++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c > @@ -89,7 +89,7 @@ AcpiTimerLibConstructor ( > // > // If ACPI I/O space is not enabled yet, program ACPI I/O base address and > enable it. > // > - if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & > EnableMask) != EnableMask)) { > + if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & > EnableMask) != EnableMask) { > PciWrite16 ( > PCI_LIB_ADDRESS (Bus, Device, Function, PcdGet16 > (PcdAcpiIoPciBarRegisterOffset)), > PcdGet16 (PcdAcpiIoPortBaseAddress) > -- > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
