Reviewed-by: Qiu Shumin <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Dandan Bi Sent: Tuesday, May 17, 2016 1:41 PM To: [email protected] Cc: Qiu, Shumin; Dong, Eric Subject: [edk2] [patch] MdeModulePkg/UiApp: Enhance the error handling
When the parameter is unsupported or invalid, should exit the function. Cc: Qiu Shumin <[email protected]> Cc: Eric Dong <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <[email protected]> Reviewed-by: Eric Dong <[email protected]> --- MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c index 80450a5..b838222 100644 --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c +++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c @@ -193,15 +193,17 @@ UiSupportLibCallbackHandler ( if (Action != EFI_BROWSER_ACTION_CHANGED) { // // Do nothing for other UEFI Action. Only do call back when data is changed. // *Status = EFI_UNSUPPORTED; + return TRUE; } if (Action == EFI_BROWSER_ACTION_CHANGED) { if ((Value == NULL) || (ActionRequest == NULL)) { *Status = EFI_INVALID_PARAMETER; + return TRUE; } *Status = EFI_SUCCESS; switch (QuestionId) { case FRONT_PAGE_KEY_CONTINUE: -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
