On 05/23/16 14:52, Gao, Liming wrote: > Andrew: > The buid output path is always in $(WORKSPACE)\Build directory. It is > not related to $(PACKAGES_PATH). PACKAGES_PATH is designed to search > source files, doesn't impact build output directory. > > I try Ovmf platform. Its AcpiTables can be found and be built into FFS.
Is it possible that Andrew's out-of-tree FDF file is missing the like of commit 259d87146b07? Thanks Laszlo > Thanks > Liming > From: af...@apple.com [mailto:af...@apple.com] > Sent: Saturday, May 21, 2016 8:21 AM > To: Gao, Liming <liming....@intel.com> > Cc: edk2-devel <edk2-devel@lists.01.org> > Subject: Re: [edk2] [BaseTools] PACKAGES_PATH issue? > > Liming, > > I found one more issues. My ACPI tables are breaking the build. It > looks like the failure is no input files. What I've figured out in > GetFileList() is FfsInf.EfiOutputPath is constructed incorrectly. The > path does not included the prefix from the PACKAGES_PATH and thus the > directory does not exist and no files are found. It looks like the > issue is __GetEFIOutPutPath__() as it is using self.InfFileName and > that has not been adjusted for PACKAGES_PATH? > > Thanks, > > Andrew Fish > >> On May 20, 2016, at 1:34 AM, Gao, Liming wrote: >> >> Andrew: >> Thanks for your point out. It is bug. Your fix is correct. I will send the >> patch for it. >> >> Thanks >> Liming >>> -----Original Message----- >>> From: af...@apple.com<mailto:af...@apple.com> [mailto:af...@apple.com] >>> Sent: Friday, May 20, 2016 1:25 PM >>> To: Gao, Liming >>> Cc: edk2-devel >>> Subject: Re: [edk2] [BaseTools] RuleOverride = BINARY code location? >>> >>> >>>> On May 19, 2016, at 8:18 PM, Gao, Liming wrote: >>>> >>>> Thanks Andrew. I will continue to investigate it. >>>> >>> >>>>>> F = 'FileNoExtention' >>>>>> os.path.splitext(F)[1] >>> '' >>>>>> '' in '.out' >>> True >>> >>> So I think the bug is the `in` it should be `==` >>>>>> '' == '.out' >>> False >>> >>> Thanks, >>> >>> Andrew Fish >>> >>> >>>>> -----Original Message----- >>>>> From: af...@apple.com<mailto:af...@apple.com> [mailto:af...@apple.com] >>>>> Sent: Friday, May 20, 2016 10:01 AM >>>>> To: Gao, Liming >>>>> Cc: edk2-devel >>>>> Subject: Re: [edk2] [BaseTools] RuleOverride = BINARY code location? >>>>> >>>>> >>>>>> On May 18, 2016, at 5:44 PM, Andrew Fish wrote: >>>>>> >>>>>>> >>>>>>> On May 18, 2016, at 5:43 PM, Gao, Liming >>> wrote: >>>>>>> >>>>>>> Andrew: >>>>>>> |.bin will search the file with the postfix .bin in INF file directory >>>>>>> and its >>>>> output directory. So, there may be more than .bin files are found. Please >>> see >>>>> the code login in GetFileList() from >>>>> C:\R9Tip\edk2\BaseTools\Source\Python\GenFds\Section.py. >>>>>>> >>>>>> >>>>> >>>>> Thanks for the pointer. >>>>> >>>>> This is the code that adding the OS executables in GetFileList() that is >>> adding >>>>> the OS executables without the .bin extension. >>>>> if os.path.exists(Makefile): >>>>> # Update to search files with suffix in all sub-dirs. >>>>> Tuple = os.walk(FfsInf.EfiOutputPath) >>>>> for Dirpath, Dirnames, Filenames in Tuple: >>>>> for F in Filenames: >>>>> if os.path.splitext(F)[1] in (Suffix): >>>>> FullName = os.path.join(Dirpath, F) >>>>> if os.path.getmtime(FullName) > >>> os.path.getmtime(Makefile): >>>>> FileList.append(FullName) >>>>> >>>>> >>>>> I think the issue is: >>>>> if os.path.splitext(F)[1] in (Suffix): >>>>> >>>>> If the file does not have an extension it matches. >>>>> >>>>> Sorry might be wrong have to go out to a writers reading with my wife so >>>>> have to stop looking right now. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>>> >>>>> Thanks, >>>>> >>>>> Andrew Fish >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> >>>> https://lists.01.org/mailman/listinfo/edk2-devel >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
