Laszlo, I am terribly sorry about that! For this patch serials, I didn't noticed your r-b. That's why I offline asked Jeff to send his r-b. I can add your tested by tag, there is no reason to ignore your review by!
For the dependency patch, I forgot your review by mail after a weekend. I will search related mails when committing patches to avoid ignoring mails again.(Outlook doesn't organize these mails from this mail list in thread style) Thanks, Ray > 在 2016年5月24日，下午8:28，Laszlo Ersek <[email protected]> 写道： > > Ray, > >> On 05/18/16 13:35, Laszlo Ersek wrote: >> >> For #1 through #3: >> Reviewed-by: Laszlo Ersek <[email protected]> > > [snip] > >> - Anyway I'll leave the above two points up to your consideration. For patch >> #4 too: >> Reviewed-by: Laszlo Ersek <[email protected]> > > I would *greatly* appreciate if you didn't ignore my (positive) reviews. > > Just because I'm not an official package maintainer for MdeModulePkg, I > do expect that my Reviewed-by tags be picked up, when I make the effort > to review MdeModulePkg patches. > > I have just noticed that you didn't pick up my above Reviewed-by tags, > for commits > > cf81d5a68052 MdeModulePkg/PciBus: use better name for local variables. > 48495aae386a MdeModulePkg/PciBus: Remove unused fields in PCI_BAR > ea669c1ba331 MdeModulePkg/PciBus: Use shorter global variable name > 05070c1b471b MdeModulePkg/PciBus: do not improperly degrade resource > > I see that you picked up my Tested-by tag (for all of the patches in > this series), but I didn't just test these patches, I also reviewed them. > > I see the exact same occur in commit > > 0b58c4894dad MdeModulePkg/PciHostBridgeDxe: Add CpuArch protocol > dependency > > I reviewed that patch on the list, but the committed version does not > have my R-b. > > In general, if you receive *any* kind of feedback tag from anyone in the > community, it is more or less your "duty" to preserve those tags when > you commit the patch. If you squander reviews that you get (even if they > are positive reviews), that's a big dis-incentive for future feedback. > > Thanks > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
