Reviewed-by: Ruiyu Ni <[email protected]> >-----Original Message----- >From: Laszlo Ersek [mailto:[email protected]] >Sent: Thursday, May 26, 2016 7:04 AM >To: edk2-devel-01 <[email protected]> >Cc: Andrew Fish <[email protected]>; Justen, Jordan L ><[email protected]>; Ni, Ruiyu <[email protected]> >Subject: [PATCH] Nt32Pkg/PlatformBootManagerLib: zero >EFI_GRAPHICS_OUTPUT_BLT_PIXEL.Reserved > >The PlatformBootManagerWaitCallback() function sets White.Reserved to >0xFF; it should be 0x00. Also, use a more compact form to assign the >component fields. > >Suggested-by: Jordan Justen <[email protected]> >Cc: Andrew Fish <[email protected]> >Cc: Jordan Justen <[email protected]> >Cc: Ruiyu Ni <[email protected]> >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Laszlo Ersek <[email protected]> >--- > Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 16 > ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c >b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c >index 82f7647c7039..007e18a956c4 100644 >--- a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c >+++ b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c >@@ -262,20 +262,20 @@ PlatformBootManagerWaitCallback ( > UINT16 TimeoutRemain > ) > { >- EFI_GRAPHICS_OUTPUT_BLT_PIXEL Black; >- EFI_GRAPHICS_OUTPUT_BLT_PIXEL White; >- UINT16 Timeout; >+ EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION Black; >+ EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION White; >+ UINT16 Timeout; > > Timeout = PcdGet16 (PcdPlatformBootTimeOut); > >- Black.Blue = Black.Green = Black.Red = Black.Reserved = 0; >- White.Blue = White.Green = White.Red = White.Reserved = 0xFF; >+ Black.Raw = 0x00000000; >+ White.Raw = 0x00FFFFFF; > > BootLogoUpdateProgress ( >- White, >- Black, >+ White.Pixel, >+ Black.Pixel, > L"Start boot option", >- White, >+ White.Pixel, > (Timeout - TimeoutRemain) * 100 / Timeout, > 0 > ); >-- >1.8.3.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
