yes I thought so.
It depends on the usage model.
if you just want to add a new/custom toolchain or change paths(these are
still in the main tools_def.txt!) the new way is definitely better because
u can just add a include for your configuration and edit paths.

But if you just want to change a few cflags, this can become somewhat
annoying since u have to manually copy the included file, edit it and
change the include path.

I also thought about copying all files and using relative include paths but
I'm not sure if that really is such a good concept on top of a system with
common includes.

Thanks
Michael

On Tue, May 31, 2016 at 4:16 PM, Gao, Liming <[email protected]> wrote:

> Michael:
>   I think this change needs some discussion. It will impact current usage
> model. Now, after tools_def.txt is copied to Conf directory, user could
> directly modify it to match its tool configuration. After this change, all
> tool chain definitions will always be kept into BaseTools\Conf. If user
> wants to customize tools setting, he will need to copy tool change
> definition file to Conf directory and modify it, then update tools_def.txt
> to include his one.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: edk2-devel [mailto:[email protected]] On Behalf Of
> > Michael Zimmermann
> > Sent: Thursday, May 26, 2016 4:05 PM
> > To: [email protected] ; Gao, Liming
> >
> > Subject: [edk2] [PATCH] BaseTools: split tools_def.txt into toolchain
> include
> > files
> >
> > this is just lots of copy-paste. I uploaded this to github because the
> > patch is pretty big.
> > https://github.com/M1cha/edk2/commits/patches/toolsdef
> >
> > Thanks
> > Michael
> > _______________________________________________
> > edk2-devel mailing list
> > [email protected]
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to