Thanks your comments. I will check-in the patches after updated them per your comments.
-----Original Message----- From: Tian, Feng Sent: Wednesday, June 01, 2016 1:56 PM To: Fan, Jeff; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: [edk2] [Patch 0/9] UefiCpuPkg/PeiCpuExceptionHandlerLib Hi, Jeff In patch #1, I didn't see you update the file comments to show it support PEI phase. In patch #8, suggest to move the HOB_GUID definition to ExceptionCommon.h file. If you fix them, you can have my RB. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, May 25, 2016 12:56 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/9] UefiCpuPkg/PeiCpuExceptionHandlerLib Add one new PeiCpuExceptionHandlerLib. It is used to be linked by CpuMpPei module to register CPU exception handler. It could handle reserved vector list and use spin lock to prevent dump message corrupted when BSP/APs encounter the exception simultaneously. Jeff Fan (9): UefiCpuPkg/ExceptionLib: Rename DxeSmmCpuException.c UefiCpuPkg/ExceptionLib: Add EXCEPTION_HANDLER_DATA definition UefiCpuPkg/ExceptionLib: Update InitializeCpuExceptionHandlersWorker UefiCpuPkg/ExceptionLib: Update UpdateIdtTable() UefiCpuPkg/ExceptionLib: Update RegisterCpuInterruptHandlerWorker() UefiCpuPkg/ExceptionLib: Add CommonExceptionHandlerWorker() UefiCpuPkg/ExceptionLib: Move global variable location UefiCpuPkg/ExceptionLib: Import PeiCpuExceptionHandlerLib module UefiCpuPkg/CpuMpPei: Consume CpuExceptionHandlerLib UefiCpuPkg/CpuMpPei/CpuMpPei.c | 21 +- UefiCpuPkg/CpuMpPei/CpuMpPei.h | 4 +- UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 5 +- .../CpuExceptionHandlerLib/CpuExceptionCommon.h | 50 +++- .../DxeCpuExceptionHandlerLib.inf | 4 +- .../Library/CpuExceptionHandlerLib/DxeException.c | 62 ++++- .../CpuExceptionHandlerLib/DxeSmmCpuException.c | 292 -------------------- .../CpuExceptionHandlerLib/PeiCpuException.c | 188 +++++++++++++ .../PeiCpuExceptionHandlerLib.inf | 61 +++++ .../PeiCpuExceptionHandlerLib.uni | 22 ++ .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 294 +++++++++++++++++++++ .../SmmCpuExceptionHandlerLib.inf | 4 +- .../Library/CpuExceptionHandlerLib/SmmException.c | 38 ++- UefiCpuPkg/UefiCpuPkg.dsc | 2 + 14 files changed, 718 insertions(+), 329 deletions(-) delete mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeSmmCpuException.c create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.uni create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c -- 2.7.4.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
