Reviewed-by: Liming Gao <[email protected]> > -----Original Message----- > From: Bi, Dandan > Sent: Wednesday, June 01, 2016 4:56 PM > To: [email protected] > Cc: Gao, Liming <[email protected]>; Dong, Eric <[email protected]> > Subject: [patch] MdeModulePkg/HiiDatabase: Remove the incorrect > calculation of font baseline > > When add Font Package, the cell in EFI_HII_FONT_PACKAGE_HDR > contains the measurement of the widest and tallest characters > in the font. The measurement may be not absolutely correct, > so when use this cell information to calculate the baseline may > cause incorrect result. Besides this calculation is not necessary. > So remove it now. > > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <[email protected]> > Reviewed-by: Eric Dong <[email protected]> > --- > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > index 56b30ff..565b6e8 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > @@ -702,14 +702,10 @@ FindGlyphBlock ( > CopyMem ( > &LocalCell, > (UINT8 *) FontPackage->FontPkgHdr + 3 * sizeof (UINT32), > sizeof (EFI_HII_GLYPH_INFO) > ); > - BaseLine = (UINT16) (LocalCell.Height + LocalCell.OffsetY); > - if (MinOffsetY > LocalCell.OffsetY) { > - MinOffsetY = LocalCell.OffsetY; > - } > } > > BlockPtr = FontPackage->GlyphBlock; > CharCurrent = 1; > BufferLen = 0; > -- > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
