On 06/06/16 10:17, Fan, Jeff wrote: > Laszlo, > > I agree. Please go ahead to check-in this serial of patches. We may > revisit it if we receive other concern in the future.
Thank you all for the feedback; series committed as d2970bbc1d88..0d0c245dfb14. Cheers, Laszlo > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Thursday, June 02, 2016 6:13 PM > To: Fan, Jeff; edk2-devel-01 > Cc: Yao, Jiewen; Justen, Jordan L; Kinney, Michael D > Subject: Re: [PATCH 0/2] UefiCpuPkg, OvmfPkg: prevent (unchecked) SMM stack > overflow > > On 06/02/16 04:15, Fan, Jeff wrote: >> Reviewed-by: Jeff Fan <[email protected]> >> >> Good suggestion to set PcdCpuSmmStackGuard default to TRUE. > > Thanks! > >> But please hold on the check-in in UefiCpuPkg.dec till next week, I >> want more platforms to be validated on this change. > > Actually, even if this change causes problems for those out-of-tree > platforms, I think it should be committed to the open source repo, and those > other platforms should set PcdCpuSmmStackGuard to FALSE in their DSC files. > > This is actually the entire point of writing patch #1 for UefiCpuPkg (the > .dec file) and not for the OVMF DSC files. I don't just want to make it safe > for OVMF -- instead, I'd like to make it safe for all other future platforms > that consume the open source edk2 tree, so that their developers don't have > to go through the same analysis that I had to. > > This is what "opt out" means -- if PcdCpuSmmStackGuard=TRUE breaks those > external platforms, then > (a) they should be fixed anyway, or > (b) if they aren't broken, just cannot afford the extra guard page, then they > should opt out of the stack guard. > > I'm aware that this could be an incompatible change for external platforms > with a very tight SMRAM budget, but even that way, it is the right thing to > do in the open source tree, for future consumers of edk2. > > Thanks > Laszlo > >> >> -----Original Message----- >> From: Laszlo Ersek [mailto:[email protected]] >> Sent: Thursday, June 02, 2016 3:03 AM >> To: edk2-devel-01 >> Cc: Fan, Jeff; Yao, Jiewen; Justen, Jordan L; Kinney, Michael D >> Subject: [PATCH 0/2] UefiCpuPkg, OvmfPkg: prevent (unchecked) SMM >> stack overflow >> >> These patches are the result of the investigation at >> <http://thread.gmane.org/gmane.comp.bios.edk2.devel/12864>. >> >> Cc: Jeff Fan <[email protected]> >> Cc: Jiewen Yao <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Cc: Michael D Kinney <[email protected]> >> >> Laszlo Ersek (2): >> UefiCpuPkg: change PcdCpuSmmStackGuard default to TRUE >> OvmfPkg: set SMM stack size to 16KB >> >> UefiCpuPkg/UefiCpuPkg.dec | 4 ++-- >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> 4 files changed, 5 insertions(+), 2 deletions(-) >> >> -- >> 1.8.3.1 >> > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
