Reviewed-by: Eric Dong <[email protected]> > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 13, 2016 9:42 AM > To: [email protected] > Cc: Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle > > In current code, when adding string package, it will return > 'gStringPackHandle'. But the code use the 'gHiiHandle' to get > string. It is incorrect. This patch is to fix this issue. > > Cc: Eric Dong <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <[email protected]> > --- > MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > index dfb37ec..dc5d1c6 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > +++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > @@ -53,11 +53,11 @@ typedef struct { > } UI_HII_DRIVER_INSTANCE; > > CHAR8 *gLanguageString; > EFI_STRING_ID *gLanguageToken; > UI_HII_DRIVER_INSTANCE *gHiiDriverList; > -EFI_HII_HANDLE gHiiHandle; > +extern EFI_HII_HANDLE gStringPackHandle; > > > /** > Get next language from language code list (with separator ';'). > > @@ -587,11 +587,11 @@ UiListThirdPartyDrivers ( > continue; > } > > String = HiiGetString (HiiHandles[Index], Token, NULL); > if (String == NULL) { > - String = HiiGetString (gHiiHandle, STRING_TOKEN (STR_MISSING_STRING), > NULL); > + String = HiiGetString (gStringPackHandle, STRING_TOKEN > (STR_MISSING_STRING), NULL); > ASSERT (String != NULL); > } else if (SpecialHandlerFn != NULL) { > // > // Check whether need to rename the driver name. > // > @@ -605,11 +605,11 @@ UiListThirdPartyDrivers ( > DriverListPtr[Count].PromptId = HiiSetString (HiiHandle, 0, String, > NULL); > FreePool (String); > > String = HiiGetString (HiiHandles[Index], TokenHelp, NULL); > if (String == NULL) { > - String = HiiGetString (gHiiHandle, STRING_TOKEN (STR_MISSING_STRING), > NULL); > + String = HiiGetString (gStringPackHandle, STRING_TOKEN > (STR_MISSING_STRING), NULL); > ASSERT (String != NULL); > } > DriverListPtr[Count].HelpId = HiiSetString (HiiHandle, 0, String, NULL); > FreePool (String); > > -- > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
