Also for the series. Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Shia, Cinnamon > Sent: Sunday, June 12, 2016 7:44 PM > To: Yao, Jiewen <[email protected]>; Zeng, Star <[email protected]>; > [email protected] > Cc: Carsey, Jaben <[email protected]>; Gao, Liming > <[email protected]> > Subject: Re: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP > Importance: High > > Series reviewed by: [email protected] > > > -----Original Message----- > From: Yao, Jiewen [mailto:[email protected]] > Sent: Sunday, June 12, 2016 3:34 PM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Carsey, Jaben <[email protected]>; Gao, Liming > <[email protected]>; Shia, Cinnamon <[email protected]> > Subject: RE: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP > > Yes, that is a better idea to maintain the dependency. > Reviewed-by: [email protected] > > > > -----Original Message----- > > From: Zeng, Star > > Sent: Sunday, June 12, 2016 3:28 PM > > To: Zeng, Star <[email protected]>; [email protected] > > Cc: Carsey, Jaben <[email protected]>; Yao, Jiewen > > <[email protected]>; Gao, Liming <[email protected]>; Cinnamon > > Shia <[email protected]> > > Subject: RE: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP > > > > Thanks all for the R-b. Sorry to disturb you again. > > Just considered more about the implementation to use PEI performance > > log HOB, that will make DP hardly depends on *PeiPerformanceLib*. > > As user may want to only dump DXE or SMM performance data, then > > PeiPerformanceLib will be not linked and PEI performance log HOB will > > be not built. > > > > DP needs performance protocol or smm performance handler to get > > performance data, the performance protocol or smm performance handler > > is installed by DxeCorePerformanceLib or SmmCorePerformanceLib. > > So it means DP requires SmmCorePerformanceLib or > > SmmCorePerformanceLib, and we can define PERFORMANCE_PROPERTY > and > > install performance property configuration table in > > DxeCorePerformanceLib and SmmCorePerformanceLib. > > > > Please review the updated patch series V3 that will define, install > > and use performance property configuration table. > > > > Thanks, > > Star > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Star Zeng > > Sent: Wednesday, June 8, 2016 6:24 PM > > To: [email protected] > > Cc: Carsey, Jaben <[email protected]>; Yao, Jiewen > > <[email protected]>; Gao, Liming <[email protected]> > > Subject: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP > > > > Current DP implementation depends on TimerLib, as different platforms > > may implement and use their own TimerLib, it makes the dp needs to be > > built by platform. The TimerLib dependency can be removed by using PEI > > performance log HOB to make DP to be generic. > > > > Cc: Liming Gao <[email protected]> > > Cc: Jiewen Yao <[email protected]> > > Cc: Cinnamon Shia <[email protected]> > > Cc: Jaben Carsey <[email protected]> Star Zeng (3): > > MdeModulePkg: Extend PEI_PERFORMANCE_LOG_HEADER > > PerformancePkg Dp_App: Remove TimerLib dependency > > ShellPkg UefiDpLib: Remove TimerLib dependency > > > > MdeModulePkg/Include/Guid/Performance.h | 9 +++-- > > .../Library/PeiPerformanceLib/PeiPerformanceLib.c | 9 +++++ > > PerformancePkg/Dp_App/Dp.c | 42 > > +++++++++++++--------- > > PerformancePkg/Dp_App/Dp.inf | 5 ++- > > PerformancePkg/Dp_App/DpInternal.h | 6 ++-- > > PerformancePkg/Dp_App/DpProfile.c | 3 +- > > PerformancePkg/Dp_App/DpStrings.uni | 10 ++++-- > > PerformancePkg/Dp_App/DpTrace.c | 25 > > ++----------- > > PerformancePkg/Dp_App/DpUtilities.c | 1 - > > PerformancePkg/Dp_App/Literals.c | 3 +- > > ShellPkg/Library/UefiDpLib/Dp.c | 40 > > +++++++++++---------- > > ShellPkg/Library/UefiDpLib/DpInternal.h | 6 ++-- > > ShellPkg/Library/UefiDpLib/DpProfile.c | 3 +- > > ShellPkg/Library/UefiDpLib/DpTrace.c | 23 +----------- > > ShellPkg/Library/UefiDpLib/DpUtilities.c | 1 - > > ShellPkg/Library/UefiDpLib/Literals.c | 3 +- > > ShellPkg/Library/UefiDpLib/UefiDpLib.inf | 7 ++-- > > ShellPkg/Library/UefiDpLib/UefiDpLib.uni | 4 ++- > > ShellPkg/ShellPkg.dsc | 2 +- > > 19 files changed, 93 insertions(+), 109 deletions(-) > > > > -- > > 2.7.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
