Yes. I will change the subject. Initially I planned to change the PCD from static to dynamic but later realized that some projects(example KBL) already using the fixed PCD.
Thanks, Satya > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, June 16, 2016 6:42 AM > To: Ma, Maurice; Yarlagadda, Satya P > Cc: Mudusuru, Giri P; [email protected] > Subject: RE: [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from > Fixed PCD to Dynamic PCD > > Agree with Maurice. How about "Add dynamic PCD capability for > PcdFspsBaseAddress"? > > With that comment change, reviewed-by: [email protected] > > > > -----Original Message----- > > From: Ma, Maurice > > Sent: Thursday, June 16, 2016 1:22 AM > > To: Yarlagadda, Satya P <[email protected]> > > Cc: Mudusuru, Giri P <[email protected]>; Yao, Jiewen > > <[email protected]>; [email protected] > > Subject: RE: [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from > > Fixed PCD to Dynamic PCD > > > > Hi, Satya, > > > > Looks fine to me. But the subject is a little bit confusing. > > > > The subject says "Change FspsBaseAddress from Fixed PCD to Dynamic > PCD". > > But the change is actually in DEC file, which just means it is possible to > > allow > > this PCD to be defined as Dynamic PCD type. It doesn't really mean the > > FspsBaseAddress will be changed from Fixed PCD to Dynamic PCD type for a > > project. > > The actual type will be determined by the project DSC file. > > > > Please consider rewording the subject. > > Reviewed by: Maurice Ma <[email protected]> > > > > Thanks > > Maurice > > > > -----Original Message----- > > From: Yarlagadda, Satya P > > Sent: Wednesday, June 15, 2016 1:16 AM > > To: [email protected] > > Cc: Mudusuru, Giri P; Ma, Maurice; Yao; Yao, Jiewen > > Subject: [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from > Fixed > > PCD to Dynamic PCD > > > > Cc: Giri P Mudusuru <[email protected]> > > Cc: Maurice Ma <[email protected]> > > Cc: Yao, Jiewen <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Satya Yarlagadda <[email protected]> > > --- > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > > index ac30e76..d9d2d80 100644 > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > > @@ -74,4 +74,7 @@ > > ## This is the base address of FSP-T/M/S > > > > > gIntelFsp2WrapperTokenSpaceGuid.PcdFsptBaseAddress|0x00000000|UINT3 > > 2|0x00000300 > > > > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress|0x00000000|UINT > > 32|0x00000301 > > - > > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress|0x00000000|UINT > > 32|0x00000302 > > + > > +[PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] > > + > > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress|0x00000000|UINT > > 32|0x00001001 > > + > > \ No newline at end of file > > -- > > 2.9.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
