Mike, Good comments. The new functions have below comments for the error return codes.
If an error would be returned, then the function will also ASSERT(). Thanks, Star -----Original Message----- From: Kinney, Michael D Sent: Friday, June 17, 2016 3:31 AM To: Zeng, Star <[email protected]>; [email protected]; Kinney, Michael D <[email protected]> Cc: Yao, Jiewen <[email protected]>; Gao, Liming <[email protected]>; Dong, Eric <[email protected]>; Tian, Feng <[email protected]>; Ni, Ruiyu <[email protected]>; Fu, Siyuan <[email protected]>; Wu, Jiaxin <[email protected]>; Carsey, Jaben <[email protected]>; Zhang, Chao B <[email protected]>; Fan, Jeff <[email protected]> Subject: RE: [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr Star, In many places in this patch series the return status is not checked. This means there is actually a behavior change with this series. The original version had ASSERT() conditions. With this new version, the ASSERT() conditions are replaced with error return codes. If the error return codes are not evaluated, then a build that has ASSERT() enabled and an ASSERT() would be triggered, will no longer see an ASSERT(). Mike > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 1:44 AM > To: [email protected] > Cc: Yao, Jiewen <[email protected]>; Gao, Liming > <[email protected]>; Kinney, Michael D > <[email protected]>; Dong, Eric <[email protected]>; Tian, > Feng <[email protected]>; Ni, Ruiyu <[email protected]>; Fu, Siyuan > <[email protected]>; Wu, Jiaxin <[email protected]>; Carsey, Jaben > <[email protected]>; Zhang, Chao B <[email protected]>; Fan, > Jeff <[email protected]> > Subject: [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 > to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with > UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. > > Cc: Jiewen Yao <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Eric Dong <[email protected]> > Cc: Feng Tian <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Cc: Siyuan Fu <[email protected]> > Cc: Jiaxin Wu <[email protected]> > Cc: Jaben Carsey <[email protected]> > Cc: Chao Zhang <[email protected]> > Cc: Jeff Fan <[email protected]> > Star Zeng (8): > MdePkg: Replace UnicodeStrToAsciiStr() with UnicodeStrToAsciiStrS() > MdeModulePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > NetworkPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > PerformancePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > SecurityPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > ShellPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > IntelFrameworkModulePkg: Replace > UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > MdePkg: Indicate UnicodeStrToAsciiStr/AsciiStrToUnicodeStr to be > deprecated > > .../Library/GenericBdsLib/BdsBoot.c | 4 +- > .../Library/LegacyBootManagerLib/LegacyBm.c | 6 +- > .../Universal/BdsDxe/FrontPage.c | 10 ++- > MdeModulePkg/Application/UiApp/FrontPage.c | 2 +- > .../UiApp/FrontPageCustomizedUiSupport.c | 6 +- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +- > MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +- > MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 18 +++-- > .../Library/UefiBootManagerLib/BmBootDescription.c | 4 +- > .../Library/VarCheckHiiLib/VarCheckHiiGen.c | 6 +- > .../HiiDatabaseDxe/ConfigKeywordHandler.c | 46 ++++++----- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 42 +++++++---- > MdePkg/Include/Library/BaseLib.h | 11 +++ > MdePkg/Library/BaseLib/String.c | 11 ++- > .../Library/UefiDevicePathLib/DevicePathFromText.c | 4 +- > .../Library/UefiFileHandleLib/UefiFileHandleLib.c | 4 +- > .../Application/IpsecConfig/PolicyEntryOperation.c | 6 +- > NetworkPkg/HttpBootDxe/HttpBootClient.c | 19 +++-- > NetworkPkg/HttpBootDxe/HttpBootConfig.c | 2 +- > NetworkPkg/HttpDxe/HttpImpl.c | 8 +- > NetworkPkg/HttpDxe/HttpProto.c | 8 +- > NetworkPkg/IScsiDxe/IScsiConfig.c | 88 > +++++++++++++++------- > NetworkPkg/IScsiDxe/IScsiDriver.c | 2 +- > NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +- > PerformancePkg/Dp_App/Dp.c | 6 +- > PerformancePkg/Dp_App/DpTrace.c | 12 +-- > SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c | 4 +- > SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 6 +- > .../Tcg/Opal/OpalPasswordDxe/OpalHiiPrivate.h | 2 +- > ShellPkg/Library/UefiDpLib/Dp.c | 8 +- > ShellPkg/Library/UefiDpLib/DpTrace.c | 10 +-- > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 8 +- > 32 files changed, 232 insertions(+), 141 deletions(-) > > -- > 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
