Thanks for aligning to the FSP spec.
Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com>
> -----Original Message-----
> From: Chan, Amy
> Sent: Friday, June 17, 2016 2:40 AM
> To: Yao, Jiewen <jiewen....@intel.com>; edk2-devel@lists.01.org
> Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Yarlagadda, Satya P
> <satya.p.yarlaga...@intel.com>; Ma, Maurice <maurice...@intel.com>
> Subject: RE: [PATCH] IntelFsp2Pkg: rename GetFspVpdDataPointer() to
> GetFspCfgRegionDataPointer()
>
> Thanks Jiewen. Looks good to me.
>
> Reviewed-by: Chan, Amy <amy.c...@intel.com>
>
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Friday, June 17, 2016 5:25 PM
> To: edk2-devel@lists.01.org
> Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Chan, Amy
> <amy.c...@intel.com>; Yarlagadda, Satya P <satya.p.yarlaga...@intel.com>;
> Ma, Maurice <maurice...@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: rename GetFspVpdDataPointer() to
> GetFspCfgRegionDataPointer()
>
> FSP2.0 removed VPD concept.
> Rename GetFspVpdDataPointer() to GetFspCfgRegionDataPointer() to follow
> FSP2.0 specification (CfgRegionOffset).
>
> Cc: Giri P Mudusuru <giri.p.mudus...@intel.com>
> Cc: Amy Chan <amy.c...@intel.com>
> Cc: Satya Yarlagadda <satya.p.yarlaga...@intel.com>
> Cc: Maurice Ma <maurice...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen....@intel.com>
> ---
> IntelFsp2Pkg/Include/Library/FspCommonLib.h | 6 +++---
> IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> b/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> index 0bb0c53..e13d0c3 100644
> --- a/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> +++ b/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> @@ -234,13 +234,13 @@ GetFspInfoHeaderFromApiContext (
> );
>
> /**
> - This function gets the VPD data pointer.
> + This function gets the CfgRegion data pointer.
>
> - @return VpdDataRgnPtr VPD data pointer.
> + @return CfgRegion data pointer.
> **/
> VOID *
> EFIAPI
> -GetFspVpdDataPointer (
> +GetFspCfgRegionDataPointer (
> VOID
> );
>
> diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> index efd55f4..151b189 100644
> --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> @@ -425,13 +425,13 @@ GetFspInfoHeaderFromApiContext ( }
>
> /**
> - This function gets the VPD data pointer.
> + This function gets the CfgRegion data pointer.
>
> - @return VpdDataRgnPtr VPD data pointer.
> + @return CfgRegion data pointer.
> **/
> VOID *
> EFIAPI
> -GetFspVpdDataPointer (
> +GetFspCfgRegionDataPointer (
> VOID
> )
> {
> --
> 2.7.4.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
