On 06/20/16 06:16, Ni, Ruiyu wrote: > Laszlo, Jaben, > > The dotdot style is copied from Shell spec V2.2 page 120 “dh” command > output sample.
Hmmm, indeed. I think that's a bit unfortunate for the spec, but then again I agree that the code follows the example. Thanks Laszlo > *From:*Carsey, Jaben > *Sent:* Saturday, June 18, 2016 5:47 AM > *To:* Laszlo Ersek <[email protected]>; Ni, Ruiyu <[email protected]>; > [email protected] > *Cc:* Carsey, Jaben <[email protected]> > *Subject:* RE: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate > device path is partially displayed > > > > 64F5B107-317A-4857-9D71-5C4165493076 > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:[email protected]] >> Sent: Friday, June 17, 2016 2:22 PM >> To: Ni, Ruiyu <[email protected] <mailto:[email protected]>>; >> [email protected] > <mailto:[email protected]> >> Cc: Carsey, Jaben <[email protected] <mailto:[email protected]>> >> Subject: Re: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path >> is partially displayed >> Importance: High >> >> On 06/16/16 05:20, Ruiyu Ni wrote: >> > The output of "dh <handle>" originally is like below: >> > 12C: USBIO DevicePath(x0)/Pci(0x14,0x0)/USB(0x6,0x0)) >> > >> > The device path part is very confusing. Use ".." in front of the >> > partially displayed device path is better and it also aligns to >> > the example output in Shell spec. >> > 12C: USBIO DevicePath(..)/Pci(0x14,0x0)/USB(0x6,0x0)) >> > >> > Ruiyu Ni (2): >> > ShellPkg: Use ".." to indicate device path is partially displayed >> > ShellPkg/UefiHandleParsingLib.c: Unify EOL and remove trailing space >> > >> > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 361 ++++++++++------- >> ---- >> > 1 file changed, 177 insertions(+), 184 deletions(-) >> > >> >> Assuming this patch is not committed yet: please consider "..." >> (triple-dot) instead of ".." (dot-dot). The latter has confusing >> connotations with "parent directory". As far as I'm concerned, this >> could be done on commit too, if Jaben doesn't mind. > > The devicepath is not really a file path, but I could see that some people > would be confused. I think changing on this same commit is also fine. > >> >> Thanks >> Laszlo > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
