Looks good to me. Thanks for eliminating the binaries and using the UefiCpuPkg.
One feedback is to remove the commented lines like comment is to remove DigitalThermalSensor Reviewed-by: Giri P Mudusuru <[email protected]> Thanks, -Giri > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Lu, > ShifeiX A > Sent: Monday, June 20, 2016 7:30 PM > To: Wei, David <[email protected]>; [email protected] > Cc: Yao, Jiewen <[email protected]> > Subject: Re: [edk2] [Patch] Vlv2TbltDevicePkg:Use PiSmmCpu of UefiCpuPkg > replace IA32FamilyCpuPkg. > > Thanks David, I will correct this change in the commit-log. > > > Shifei > -----Original Message----- > From: Wei, David > Sent: Tuesday, June 21, 2016 10:28 AM > To: Lu, ShifeiX A; [email protected] > Cc: Wei, David; Yao, Jiewen > Subject: RE: [Patch] Vlv2TbltDevicePkg:Use PiSmmCpu of UefiCpuPkg replace > IA32FamilyCpuPkg. > > Looks like PiSmmCommunicationSmm are also replaced. Could you also describe > this change in the commit-log? And also there is grammar error in the title " > Use > PiSmmCpu of UefiCpuPkg replace IA32FamilyCpuPkg." > > Thanks, > David Wei > > Intel SSG BIOS Team > > > -----Original Message----- > From: Lu, ShifeiX A > Sent: Tuesday, June 21, 2016 10:16 AM > To: [email protected] > Cc: Wei; Wei, David <[email protected]> > Subject: [Patch] Vlv2TbltDevicePkg:Use PiSmmCpu of UefiCpuPkg replace > IA32FamilyCpuPkg. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: lushifex <[email protected]> > --- > Vlv2TbltDevicePkg/PlatformPkg.fdf | 4 ++-- > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 4 ++-- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 6 ++++-- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 ++++-- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 ++++-- > 5 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf > b/Vlv2TbltDevicePkg/PlatformPkg.fdf > index a499006..2ce2217 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf > @@ -540,15 +540,15 @@ INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET > # > # SMM > # > INF MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > INF MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > -INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCpuDxeSmm.inf > +INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > > INF UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > -INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCommunicationSmm.inf > +INF UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > INF > $(PLATFORM_PACKAGE)/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDis > patch2OnSmmSwDispatchThunk.inf > INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PowerManagement2.inf > # INF > Vlv2DeviceRefCodePkg/ValleyView2Soc/CPU/Dts/Smm/DigitalThermalSensor.in > f > INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/DigitalThermalSensor.inf > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > index 72a0d2b..92284ee 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > @@ -497,15 +497,15 @@ INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET > # > # SMM > # > INF MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > INF MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > -INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCpuDxeSmm.inf > +INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > > INF UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > -INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCommunicationSmm.inf > +INF UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > INF > $(PLATFORM_PACKAGE)/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDis > patch2OnSmmSwDispatchThunk.inf > INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PowerManagement2.inf > # INF > Vlv2DeviceRefCodePkg/ValleyView2Soc/CPU/Dts/Smm/DigitalThermalSensor.in > f > INF RuleOverride = BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/DigitalThermalSensor.inf > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index 466de88..9865785 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -398,10 +398,12 @@ > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmR > eportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemory > AllocationLib.inf > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLib > Null.inf > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > + > + > SmmCpuPlatformHookLib|UefiCpuPkg/Library/SmmCpuPlatformHookLibNull/S > mm > + CpuPlatformHookLibNull.inf > + > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatures > L > + ib.inf > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > !if $(TARGET) != RELEASE > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !endif > @@ -1328,14 +1330,14 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMI > nitPeim.inf > <LibraryClasses> > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf > !endif > } > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCommunicationSmm.inf > + UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > > $(PLATFORM_PACKAGE)/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDis > patch2OnSmmSwDispatchThunk.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PowerManagement2.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/DigitalThermalSensor.inf > > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index b7e1446..32dda41 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -398,10 +398,12 @@ > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmR > eportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemory > AllocationLib.inf > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLib > Null.inf > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > + > + > SmmCpuPlatformHookLib|UefiCpuPkg/Library/SmmCpuPlatformHookLibNull/S > mm > + CpuPlatformHookLibNull.inf > + > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatures > L > + ib.inf > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif > @@ -1309,14 +1311,14 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMI > nitPeim.inf > # > # SMM > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCommunicationSmm.inf > + UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > > $(PLATFORM_PACKAGE)/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDis > patch2OnSmmSwDispatchThunk.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PowerManagement2.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/DigitalThermalSensor.inf > > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index b4a35ee..a176041 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -398,10 +398,12 @@ > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmR > eportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemory > AllocationLib.inf > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLib > Null.inf > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > + > + > SmmCpuPlatformHookLib|UefiCpuPkg/Library/SmmCpuPlatformHookLibNull/S > mm > + CpuPlatformHookLibNull.inf > + > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatures > L > + ib.inf > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif > @@ -1315,14 +1317,14 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMI > nitPeim.inf > # > # SMM > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > - > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PiSmmCommunicationSmm.inf > + UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > > $(PLATFORM_PACKAGE)/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDis > patch2OnSmmSwDispatchThunk.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/PowerManagement2.inf > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARC > HITECTURE)/DigitalThermalSensor.inf > > # > -- > 2.6.2.windows.1 > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
