Laszlo: Thanks! If no more comments, I plan to push those patches early next week.
Thanks Liming > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 23, 2016 2:44 AM > To: Gao, Liming <liming....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [Patch 000/351] Convert EDK II core packages to NASM > for IA32/X64 > > On 06/22/16 05:15, Gao, Liming wrote: > > Laszlo: > > I don't find any other case. I have integrated your patches into > > https://github.com/lgao4/edk2.git branch nasm-v2. Please help check. > > I retested the SMM_REQUIRE + S3 cases (Ia32 Fedora, Ia32X64 Fedora, > Ia32X64 Windows 8.1), with your nasm-v2 branch (at commit > 7c10e13e7c36c593bb102ddc5ae27a747457097f). Everything seems to work > fine. > > I also checked the UefiCpuPkg/PiSmmCpuDxeSmm/*/MpFuncs.nasm files; > they > look good. > > The commit messages on > > 9bdcbb94016c3 UefiCpuPkg PiSmmCpuDxeSmm: Update > Ia32/MpFuncs.nasm > f6083bde349ce UefiCpuPkg PiSmmCpuDxeSmm: Update X64/MpFuncs.nasm > > seem fine as well. > > Thanks! > Laszlo > > > > > Thanks > > Liming > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Tuesday, June 21, 2016 10:37 AM > > To: Gao, Liming <liming....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> > > Cc: edk2-de...@ml01.01.org > > Subject: Re: [edk2] [Patch 000/351] Convert EDK II core packages to NASM > for IA32/X64 > > > > On 06/21/16 03:54, Gao, Liming wrote: > >> Laszlo: > >> Thanks for your test and finding. I notice this difference between > >> asm and nasm output file. I read IA32 manual to try understanding 66 > >> and 67 prefix operand. I wrongly think 66 has the same functionality > >> to 66 67. So, I think they are same. I will go through all patches to > >> make sure there is no other 67 missing. > >> > >> ASM dump: > >> 00000032: 66 67 EA 00 00 00 jmp _RendezvousFunnelProc > >> 00 > >> NASM dump: > >> 00000032: 66 EA 00 00 00 00 jmp _RendezvousFunnelProc > > > > Right, that's the pattern. > > > > Thanks! > > Laszlo > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
