Looks good to me.
Reviewed-by: Giri P Mudusuru <[email protected]> 

> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of
> Liming Gao
> Sent: Thursday, June 23, 2016 2:50 AM
> To: [email protected]
> Subject: [edk2] [Patch 1/2] SecurityPkg: Add PcdUserPhysicalPresence to
> indicate use physical presence.
> 
> This PCD supports all configuration type. Its default value is FALSE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <[email protected]>
> ---
>  SecurityPkg/SecurityPkg.dec | 6 ++++++
>  SecurityPkg/SecurityPkg.uni | 9 +++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> index a9da5a6..f4f4d19 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -414,6 +414,12 @@
>    # @Prompt Length(in bytes) of the TCG2 Final event log area.
> 
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2FinalLogAreaLen|0x8000|UINT32|0x00
> 010018
> 
> +  ## Indicate whether a physical presence user exist.
> +  # When it is configured to Dynamic or DynamicEx, it can be set through
> detection using
> +  # a platform-specific method (e.g. Button pressed) in a actual platform in
> early boot phase.<BR><BR>
> +  # @Prompt A physical presence user status
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|FALSE|BOOLEAN|0x0
> 0010019
> +
>  [PcdsDynamic, PcdsDynamicEx]
> 
>    ## This PCD indicates Hash mask for TPM 2.0.<BR><BR>
> diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni
> index 432a77b..17a6842 100644
> --- a/SecurityPkg/SecurityPkg.uni
> +++ b/SecurityPkg/SecurityPkg.uni
> @@ -205,3 +205,12 @@
> 
>  #string
> STR_gEfiSecurityPkgTokenSpaceGuid_PcdTcgPhysicalPresenceInterfaceVer_HEL
> P  #language en-US "Null-terminated string of the Version of Physical Presence
> interface supported by platform."
> 
> +#string
> STR_gEfiSecurityPkgTokenSpaceGuid_PcdUserPhysicalPresence_PROMPT
> +#language en-US
> +"A physical presence user status"
> +
> +#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdUserPhysicalPresence_HELP
> +#language en-US
> +"Indicate whether a physical presence user exist. "
> +"When it is configured to Dynamic or DynamicEx, it can be set through
> detection using "
> +"a platform-specific method (e.g. Button pressed) in a actual platform in 
> early
> boot phase.<BR><BR>"
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to