Looks good to me! Reviewed-By: Wu Jiaxin <[email protected]>
Best Regards! Jiaxin > -----Original Message----- > From: Fu, Siyuan > Sent: Tuesday, June 28, 2016 4:32 PM > To: [email protected] > Cc: Ye, Ting <[email protected]>; Wu, Jiaxin <[email protected]> > Subject: [Patch] NetworkPkg: Stop the HTTP Boot service after the boot > image download complete. > > After boot image has been downloaded, the HTTP boot driver leaves the > service in the started state, with an active TCP child. This may cause some > problems: > 1. The HTTP session may become unavaiable after a while, then a following > HTTP Boot will fail. > 2. An active TCP child will send RST to any incoming TCP message, which may > break other driver which tries to setup a TCP connection. > The HTTP boot driver doesn't provide any interface to the boot loader, so it's > unnecessary to keep the service running after a boot image is downloaded. > > Cc: Ye Ting <[email protected]> > Cc: Wu Jiaxin <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Fu Siyuan <[email protected]> > --- > NetworkPkg/HttpBootDxe/HttpBootImpl.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c > b/NetworkPkg/HttpBootDxe/HttpBootImpl.c > index 4b850b6..babd3e6 100644 > --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c > +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c > @@ -505,7 +505,11 @@ HttpBootDxeLoadFile ( > Status = EFI_WARN_FILE_SYSTEM; > } > } > - > + > + // > + // Stop the HTTP Boot service after the boot image is downloaded. > + // > + HttpBootStop (Private); > return Status; > } > > -- > 2.7.4.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
