On 28/06/16 13:30, Laszlo Ersek wrote:
On 06/24/16 06:39, Gary Lin wrote:
It seems that iPXE didn't initialize Scope, so the value was assigned
randomly (sort of).

diff --git a/src/interface/efi/efi_hii.c b/src/interface/efi/efi_hii.c
index 0ea970e..4b5aa9a 100644
--- a/src/interface/efi/efi_hii.c
+++ b/src/interface/efi/efi_hii.c
@@ -119,6 +119,7 @@ static void * efi_ifr_op ( struct efi_ifr_builder *ifr, 
unsigned int opcode,
        /* Fill in opcode header */
        op->OpCode = opcode;
        op->Length = len;
+       op->Scope = 0;

        return op;
  }

After applying this patch, the crash never happened again.

Awesome! Can you please send this patch to ipxe-devel? (Although I can
see Michael is on the address list anyway -- good!)

Got it; thank you!

Will check the related code; it may make sense to have efi_ifr_op() always zero the whole of the newly allocated space first.

Thanks again!

Michael
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to