Hi, Anandakrishnan Your patch makes the build break.
warning C4005: 'ATA_CMD_SEEK': macro redefinition I would submit patch to update those ATPI cmds prefix from ATA_ to ATAPI_. Thanks Feng -----Original Message----- From: Tian, Feng Sent: Tuesday, June 28, 2016 9:37 PM To: Gao, Liming <[email protected]>; Anandakrishnan Loganathan <[email protected]>; [email protected] Cc: Tian, Feng <[email protected]> Subject: RE: [PATCH] [MdePkg ] Additional Atapi.h definitions complying Industry Standard specifications. Hi, Anandakrishnan Reviewed-by: Feng Tian <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Gao, Liming Sent: Monday, June 27, 2016 5:15 PM To: Anandakrishnan Loganathan <[email protected]>; [email protected] Subject: Re: [edk2] [PATCH] [MdePkg ] Additional Atapi.h definitions complying Industry Standard specifications. Got it. We will review this change. > -----Original Message----- > From: Anandakrishnan Loganathan [mailto:[email protected]] > Sent: Monday, June 27, 2016 5:12 PM > To: Gao, Liming <[email protected]>; [email protected] > Subject: RE: [PATCH] [MdePkg ] Additional Atapi.h definitions > complying Industry Standard specifications. > > Hi Gao, > > Sorry.. I will check the problem in creating the patch my side. > Meanwhile I have attached the Atapi.h for your reference > > Thanks! > > > -----Original Message----- > From: Gao, Liming [mailto:[email protected]] > Sent: 27 June 2016 14:33 > To: Anandakrishnan Loganathan; [email protected] > Subject: RE: [PATCH] [MdePkg ] Additional Atapi.h definitions > complying Industry Standard specifications. > > Anandakrishnan: > Your patch format is Unicode. I can't apply it. Could you create > the normal GIT patch or directly send the updated Atapi.h? > > > -----Original Message----- > > From: Anandakrishnan Loganathan [mailto:[email protected]] > > Sent: Monday, June 27, 2016 2:02 PM > > To: Gao, Liming <[email protected]>; [email protected] > > Subject: RE: [PATCH] [MdePkg ] Additional Atapi.h definitions > > complying Industry Standard specifications. > > > > Attached the Patch with the mail > > > > -----Original Message----- > > From: Gao, Liming [mailto:[email protected]] > > Sent: 27 June 2016 09:41 > > To: Anandakrishnan Loganathan; [email protected] > > Subject: RE: [PATCH] [MdePkg ] Additional Atapi.h definitions > > complying Industry Standard specifications. > > > > Hi, could you attach your patch? > > > > > -----Original Message----- > > > From: edk2-devel [mailto:[email protected]] On > > > Behalf Of Anandakrishnan Loganathan > > > Sent: Friday, June 24, 2016 4:56 PM > > > To: [email protected] > > > Subject: [edk2] [PATCH] [MdePkg ] Additional Atapi.h definitions > > > complying Industry Standard specifications. > > > > > > Dear MdePkg maintainer, > > > > > > > > > Atapi.h has only limited ATA/ATAPI related specification > > > definitions and this attached patch includes various commonly > > > usage Industry Standard definitions in Atapi.h. Please review and > > > update to the > MdePkg. > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Anandakrishnan Loganathan > > > [email protected]<mailto:[email protected]> > > > > > > > > > Thanks! > > > Anandakrishnan > > > _______________________________________________ > > > edk2-devel mailing list > > > [email protected] > > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
