Jordan, I misunderstood your option. I am fine to add a new library class FrameBufferBltLib and leave BltLib as is.
Thanks, Ray -----Original Message----- From: Justen, Jordan L Sent: Thursday, June 30, 2016 4:42 AM To: Ni, Ruiyu <[email protected]>; [email protected] Subject: Re: [edk2] [PATCH 0/9] Add FrameBufferBltLib and generic GOP driver to MdeModulePkg. On 2016-06-29 06:24:31, Ruiyu Ni wrote: > The patch serials refine the FrameBufferBltLib in OptionRomPkg and > move it to MdeModulePkg. Based on the library, a generic GOP driver > GraphicsOutputDxe is developed and added to MdeModulePkg. > > Ruiyu Ni (9): > OptionRomPkg: Refine FrameBufferBltLib to use UINT8* instead of VOID* > OptionRomPkg: Add video move test case to BltLibSample application > OptionRomPkg/BltLib: Fix a bug in BltVideoToVideo operation > OptionRomPkg: Remove GopBltLib instance > OptionRomPkg: Refine BltLib to FrameBufferBltLib > MdeModulePkg: Move OptionRomPkg/FrameBufferBltLib to MdeModulePkg When we last discussed this, the plan was to add the FrameBufferBltLib interface, but leave BltLib as it is for now. I recommend adding the library interface and implementations in separate commits. Can you make that change, and make a branch available with the changes? -Jordan > OvmfPkg: QemuVideoDxe uses MdeModulePkg/FrameBufferLib > MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and structure > MdeModulePkg: Add GraphicsOutputDxe driver. > > MdeModulePkg/Include/Library/FrameBufferBltLib.h | 90 +++ > .../Library/FrameBufferBltLib/FrameBufferBltLib.c | 709 +++++++++++++++++++ > .../FrameBufferBltLib/FrameBufferBltLib.inf | 5 +- > MdeModulePkg/MdeModulePkg.dec | 4 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../Console/GraphicsOutputDxe/ComponentName.c | 190 ++++++ > .../Console/GraphicsOutputDxe/GraphicsOutput.c | 732 ++++++++++++++++++++ > .../Console/GraphicsOutputDxe/GraphicsOutput.h | 59 ++ > .../GraphicsOutputDxe/GraphicsOutputDxe.inf | 55 +- > MdePkg/Include/Guid/GraphicsInfoHob.h | 17 +- > MdePkg/MdePkg.dec | 1 + > .../Application/BltLibSample/BltLibSample.c | 145 ++-- > .../Application/BltLibSample/BltLibSample.inf | 5 +- > OptionRomPkg/Include/Library/BltLib.h | 259 ------- > .../Library/FrameBufferBltLib/FrameBufferBltLib.c | 750 > --------------------- > OptionRomPkg/Library/GopBltLib/GopBltLib.c | 455 ------------- > OptionRomPkg/Library/GopBltLib/GopBltLib.inf | 37 - > OptionRomPkg/OptionRomPkg.dec | 11 +- > OptionRomPkg/OptionRomPkg.dsc | 7 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 6 +- > OvmfPkg/QemuVideoDxe/Gop.c | 38 +- > OvmfPkg/QemuVideoDxe/Qemu.h | 4 +- > OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 5 +- > 23 files changed, 1969 insertions(+), 1618 deletions(-) create mode > 100644 MdeModulePkg/Include/Library/FrameBufferBltLib.h > create mode 100644 > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > rename {OptionRomPkg => > MdeModulePkg}/Library/FrameBufferBltLib/FrameBufferBltLib.inf (87%) > create mode 100644 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/ComponentName.c > create mode 100644 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutput.c > create mode 100644 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutput.h > copy OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf => > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf > (53%) delete mode 100644 OptionRomPkg/Include/Library/BltLib.h > delete mode 100644 > OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > delete mode 100644 OptionRomPkg/Library/GopBltLib/GopBltLib.c > delete mode 100644 OptionRomPkg/Library/GopBltLib/GopBltLib.inf > > -- > 2.8.3.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
