Reviewed-by: Giri P Mudusuru <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Gao, Liming > Sent: Tuesday, June 28, 2016 11:37 PM > To: Laszlo Ersek <[email protected]>; edk2-devel-01 <edk2- > [email protected]> > Subject: Re: [edk2] [PATCH 1/6] EdkCompatibilityPkg: fix > ASSERT_EFI_ERROR() typos > > Reviewed-by: Liming Gao <[email protected]> > > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Tuesday, June 28, 2016 9:26 PM > To: edk2-devel-01 <[email protected]> > Cc: Gao, Liming <[email protected]> > Subject: [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos > > A number of code locations use > > ASSERT_EFI_ERROR (BooleanExpression) > > instead of > > ASSERT (BooleanExpression) > > Fix them. > > Cc: Liming Gao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <[email protected]> > --- > > Notes: > build tested only > > > EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabas > e.c | 2 +- > EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c > | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatab > ase.c > b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatab > ase.c > index 386ff327f81b..2d456da30353 100644 > --- > a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatab > ase.c > +++ > b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatab > ase.c > @@ -494,7 +494,7 @@ HiiGetSecondaryLanguages ( > UnicodeStrToAsciiStr (PrimaryLanguage, PrimaryLang639); > > PrimaryLang4646 = ConvertLanguagesIso639ToRfc4646 (PrimaryLang639); > - ASSERT_EFI_ERROR (PrimaryLang4646 != NULL); > + ASSERT (PrimaryLang4646 != NULL); > > SecLangCodes4646 = HiiGetSupportedSecondaryLanguages (UefiHiiHandle, > PrimaryLang4646); > > diff --git > a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c > b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c > index f6d97f63444f..d269b8e4d6ba 100644 > --- > a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c > +++ > b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c > @@ -153,7 +153,7 @@ ExportPackageLists ( > &Size, > PackageListHdr > ); > - ASSERT_EFI_ERROR (Status != EFI_BUFFER_TOO_SMALL); > + ASSERT (Status != EFI_BUFFER_TOO_SMALL); > > if (Status == EFI_BUFFER_TOO_SMALL) { > PackageListHdr = AllocateZeroPool (Size); > -- > 1.8.3.1 > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
