Jordan, Thanks for the suggestions. I agree with both of your suggestions. What's your plan about BltLib in OptionRomPkg?
Thanks, Ray > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, June 30, 2016 1:54 PM > To: Ni, Ruiyu <[email protected]>; [email protected] > Subject: Re: [edk2] [PATCH v3 0/3] Add FrameBufferBltLib and > GraphicsOutputDxe to MdeModulePkg > > I have two suggestions: > > 1. Split "MdeModulePkg: Add FrameBufferBltLib" into two patches. I > prefer to add the library "interface" first (.dec and library .h > files fist), and then add the library implementation second. I like > to think about the interface as separate from the implementation. > > I don't think this is a strict requirement, but just my suggestion. > > 2. Re-add "OvmfPkg: QemuVideoDxe uses MdeModulePkg/FrameBufferLib" > > I did want you to update OVMF's GOP driver to use the new > interface. > > But, please also modify the IA32 and X64 .dsc files in that patch. > > This series, with the OVMF patch: > > Reviewed-by: Jordan Justen <[email protected]> > > On 2016-06-29 22:09:29, Ruiyu Ni wrote: > > The patch serials add FrameBufferBltLib and GraphicsOutputDxe driver > > to MdeModulePkg. > > FrameBufferBltLib provides interfaces to perform UEFI Graphics Output > > Protocol Video BLT operations GraphicsOutputDxe uses the GraphicsInfo > > HOB and GraphicsDeviceInfo HOB passed from PEI to find the graphics > > controller to manage and produce the GraphicsOutput protocol. > > > > GraphicsInfo HOB and GraphicsDeviceInfo HOB are created by a PEIM > > which initializes the graphics controller hardware in PEI phase. > > > > https://github.com/niruiyu/edk2/commits/Gop3 > > > > Ruiyu Ni (3): > > MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and > structure > > MdeModulePkg: Add FrameBufferBltLib > > MdeModulePkg: Add GraphicsOutputDxe driver. > > > > MdeModulePkg/Include/Library/FrameBufferBltLib.h | 94 +++ > > .../Library/FrameBufferBltLib/FrameBufferBltLib.c | 704 > ++++++++++++++++++++ > > .../FrameBufferBltLib/FrameBufferBltLib.inf | 34 + > > MdeModulePkg/MdeModulePkg.dec | 4 + > > MdeModulePkg/MdeModulePkg.dsc | 3 + > > .../Console/GraphicsOutputDxe/ComponentName.c | 190 ++++++ > > .../Console/GraphicsOutputDxe/GraphicsOutput.c | 735 > +++++++++++++++++++++ > > .../Console/GraphicsOutputDxe/GraphicsOutput.h | 59 ++ > > .../GraphicsOutputDxe/GraphicsOutputDxe.inf | 58 ++ > > MdePkg/Include/Guid/GraphicsInfoHob.h | 17 +- > > MdePkg/MdePkg.dec | 1 + > > 11 files changed, 1898 insertions(+), 1 deletion(-) create mode > > 100644 MdeModulePkg/Include/Library/FrameBufferBltLib.h > > create mode 100644 > > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > create mode 100644 > > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf > > create mode 100644 > > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/ComponentName.c > > create mode 100644 > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutput.c > > create mode 100644 > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutput.h > > create mode 100644 > > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > > > > -- > > 2.8.3.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
