Reviewed-By: Wu Jiaxin <[email protected]>

Best Regards!
Jiaxin

> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of
> Hao Wu
> Sent: Tuesday, July 5, 2016 12:59 PM
> To: [email protected]
> Cc: Wu, Hao A <[email protected]>; Ye, Ting <[email protected]>; Fu,
> Siyuan <[email protected]>; Wu, Jiaxin <[email protected]>
> Subject: [edk2] [PATCH v2] MdeModulePkg UefiPxeBcDxe: Fix build error for
> lastest VS2015 compiler
> 
> The UefiPxeBcDxe module encounters a build error for IA32 arch using the
> latest version of VS2015:
> 
> UefiPxe4BcDxe.lib(PxeBcDhcp.obj) : error LNK2001: unresolved external
> symbol __allmul
> 
> The cause is line 1659 in file
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c. The third
> parameter for gBS->SetTimer() function is of type UINT64, so the
> multiplication should use the MultU64x32() function.
> 
> Cc: Ye Ting <[email protected]>
> Cc: Fu Siyuan <[email protected]>
> Cc: Wu Jiaxin <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <[email protected]>
> ---
>  MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
> b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
> index 3849613..eac955c 100644
> --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
> +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
> @@ -1656,7 +1656,7 @@ PxeBcSelectBootPrompt (
>    Status = gBS->SetTimer (
>                    TimeoutEvent,
>                    TimerRelative,
> -                  Timeout * TICKS_PER_SECOND
> +                  MultU64x32 (Timeout, TICKS_PER_SECOND)
>                    );
> 
>    if (EFI_ERROR (Status)) {
> --
> 1.9.5.msysgit.0
> 
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to