Will check this. I didn't validate RVCT build before. I am curious if this is one new link issue?
Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Cohen, Eugene > Sent: Wednesday, July 06, 2016 4:07 AM > To: David Woodhouse; Ard Biesheuvel; [email protected]; Long, Qin; > Ye, Ting > Cc: [email protected] > Subject: [edk2] [PATCH] CryptoPkg: Fix openssl bn_exp to avoid alloca on > RVCT > > One more thing, I'm not sure how you want to address it, upstreaming or > modifying the edk2 patch... > > We also ran into an issue where we had to qualify the __GNUC__ check to > exclude RVCT so that alloca wasn't used for allocations (it caused linker > errors > trying to get library support that didn't exist). Not defining it causes > openssl > to use malloc instead. > > Can you help upstream this one-liner? > > Thanks, > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen <[email protected]> > -- > > edk2/CryptoPkg/Library/OpensslLib/openssl-1.0.2g/crypto/bn/bn_exp.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edk2/CryptoPkg/Library/OpensslLib/openssl- > 1.0.2g/crypto/bn/bn_exp.c b/edk2/CryptoPkg/Library/OpensslLib/openssl- > 1.0.2g/crypto/bn/bn_exp.c > index 1670f01..960228f 100644 > --- a/edk2/CryptoPkg/Library/OpensslLib/openssl- > 1.0.2g/crypto/bn/bn_exp.c > +++ b/edk2/CryptoPkg/Library/OpensslLib/openssl- > 1.0.2g/crypto/bn/bn_exp. > +++ c > @@ -119,7 +119,7 @@ > # ifndef alloca > # define alloca _alloca > # endif > -#elif defined(__GNUC__) > +#elif defined(__GNUC__) && !defined(__CC_ARM) > # ifndef alloca > # define alloca(s) __builtin_alloca((s)) # endif > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Cohen, Eugene > > Sent: Tuesday, July 05, 2016 11:07 AM > > To: David Woodhouse <[email protected]>; Ard Biesheuvel > > <[email protected]>; [email protected]; Qin Long > > <[email protected]>; Ting Ye <[email protected]> > > Cc: [email protected] <[email protected]> > > Subject: Re: [edk2] [PATCH] CryptoPkg: update openssl to ignore RVCT > > 3079 > > > > > > corrects x509_vfy.c(875): error C3017: ok may be used before being > > > set > > > > > > > > Change-Id: I0d38193569b29f96861a191908c343831fd957c2 > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: Eugene Cohen <[email protected]> > > > > > > Can we "fix" the upstream code instead? > > > > No objection here - could I provide a patch that initializes 'ok' and > > work with someone who already contributes to openssl to upstream it? > > > > Eugene > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
