Hi Liming, yes, that would be great. Thank you.
Peter -----Original Message----- From: Gao, Liming [mailto:[email protected]] Sent: Thursday, July 07, 2016 11:22 AM To: Kirmeier, Peter; [email protected] Subject: RE: Build fails due to missing NASM Peter: Thanks for your suggestion. I think we can add the dependency check in edksetup.bat/edksetup.sh. If nasm is not installed, setup script will report warning message to user. Meanwhile, we can update wiki https://github.com/tianocore/tianocore.github.io/wiki/Getting%20Started%20with%20EDK%20II to document nasm is required. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > [email protected] > Sent: Thursday, July 07, 2016 5:09 PM > To: Gao, Liming <[email protected]>; [email protected] > Subject: Re: [edk2] Build fails due to missing NASM > > Hi Liming, > > yes I see, but there are lots of people not reading every single patch > note of this email list or don't even are part of the list. However, > also newcomers who don't know the past (or this email list at all) > won't know anything about such changes happening in the background. > Therefore it is essential to update the documentation of the source > code accordingly. In best case the documentation is part of the PATCH > itself, like an README update. Moreover especially for changes, which > take effect on the build environment or dependencies to third party > software, it is absolutely necessary to document these changes, so > everyone can see what was going on and/or what they have to do. > > Best Regards, > Peter > > > -----Original Message----- > From: Gao, Liming [mailto:[email protected]] > Sent: Thursday, July 07, 2016 10:49 AM > To: Kirmeier, Peter; [email protected] > Subject: RE: Build fails due to missing NASM > > Peter: > I mention such information in my sent patch to edk2 community. > Please see > http://article.gmane.org/gmane.comp.bios.edk2.devel/13297 > > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf > > Of [email protected] > > Sent: Thursday, July 07, 2016 4:13 PM > > To: [email protected] > > Subject: [edk2] Build fails due to missing NASM > > > > Hello, > > > > I just updated our local edk2 fork and there were a lot of new .nasm > > files added. > > Unfortunately this update was not compiling any more. > > The reason is that we don't have the tool NASM installed. > > I got it back working again by installing NASM but what I want to > > mention > > here: > > > > I was missing either > > an update of any README telling me that NASM is now required or > > an update of the build tools that have NASM integrated or > > support for backward compatibility (a way avoiding NASM installation). > > > > If none of them is preset, failing builds are pre-programmed for > > anyone who wasn't aware of the tool change and doesn't have NASM > installed. > > > > Best Regards, > > Peter > > > > --- > > Peter Kirmeier > > Senior Firmware Developer > > Client Computing Devices Engineering [logo] FUJITSU > > Buergermeister-Ulrich-Strasse 100, 86199 Augsburg, Germany > > Tel.: +49 (821) 804 3227 > > Fax: +49 (821) 804 83227 > > E-mail: > > [email protected]<mailto:[email protected]> > > Web: ts.fujitsu.com<http://ts.fujitsu.com/> > > Company: Fujitsu Technology Solutions GmbH / > > ts.fujitsu.com/imprint<http://ts.fujitsu.com/imprint.html> > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
