Thanks Laszlo for your comments. Will send updated patch addressing your comments.
Thanks, -Giri > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 7, 2016 2:00 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com> > Cc: edk2-de...@ml01.01.org; Justen, Jordan L <jordan.l.jus...@intel.com> > Subject: Re: [edk2] [PATCH 14/16] OvmfPkg: Series of patches to fix typos - > accessibla to accessible - exeuction to execution - iff to if > > Giri, > > On 07/07/16 09:47, Giri P Mudusuru wrote: > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Laszlo Ersek <ler...@redhat.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > > --- > > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +- > > OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +- > > OvmfPkg/SmmAccess/SmramInternal.c | 4 ++-- > > OvmfPkg/SmmAccess/SmramInternal.h | 4 ++-- > > OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 8 ++++---- > > OvmfPkg/VirtioBlkDxe/VirtioBlk.h | 4 ++-- > > OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c | 2 +- > > OvmfPkg/XenIoPciDxe/XenIoPciDxe.c | 2 +- > > 8 files changed, 14 insertions(+), 14 deletions(-) > > thanks for this contribution. I have some comments: > > (1) The subject line is way too long. It should be 74 characters tops > (maybe a bit more, 76-78, if it's simply impossible to squeeze the > information in 74 characters). > > (2) The subject line is not correct. First, it is just one patch for > OvmfPkg, not a series of patches. Second, you don't need to list all the > typos you fix. I think the following would be better, as subject: > > OvmfPkg: fix typos > > and in the commit message body you can summarize the typos that you fix. > > (3) The word "iff" is not a typo. It means "if and only if". Please > refer to: > > https://en.wiktionary.org/wiki/iff > > (4) In the commit message, the various labels (Cc:, Contributed-under:, > Signed-off-by:) should be indented fully to the left. > > I think you used "git show" to see an example, and copied that block > into your commit message. That's okay, but "git show" automatically > indents the commit message by 4 spaces, so you have to undo that when > pasting. > > Thank you, > Laszlo > > > > > > diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > > index faaff37..5ab8b8c 100644 > > --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > > +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > > @@ -35,7 +35,7 @@ typedef struct { > > // key. > > UINTN Size; // The number of bytes in this > > blob. > > UINT8 *Base; // Pointer to the blob data. > > - BOOLEAN HostsOnlyTableData; // TRUE iff the blob has been > > found to > > + BOOLEAN HostsOnlyTableData; // TRUE if the blob has been found > > to > > // only contain data that is > > directly > > // part of ACPI tables. > > } BLOB; > > diff --git a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h > b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h > > index 625a0fc..83615a9 100644 > > --- a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h > > +++ b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h > > @@ -341,7 +341,7 @@ typedef UINT64 xen_callback_t; > > #define PSR_MODE_SYS 0x1f > > > > /* 64 bit modes */ > > -#define PSR_MODE_BIT 0x10 /* Set iff AArch32 */ > > +#define PSR_MODE_BIT 0x10 /* Set if AArch32 */ > > #define PSR_MODE_EL3h 0x0d > > #define PSR_MODE_EL3t 0x0c > > #define PSR_MODE_EL2h 0x09 > > diff --git a/OvmfPkg/SmmAccess/SmramInternal.c > b/OvmfPkg/SmmAccess/SmramInternal.c > > index c3267ca..d31056f 100644 > > --- a/OvmfPkg/SmmAccess/SmramInternal.c > > +++ b/OvmfPkg/SmmAccess/SmramInternal.c > > @@ -30,10 +30,10 @@ > > the LockState and OpenState fields being up-to-date on entry, and they > > need > > to restore the same invariant on exit, if they touch the bits in > > question. > > > > - @param[out] LockState Reflects the D_LCK bit on output; TRUE iff SMRAM > is > > + @param[out] LockState Reflects the D_LCK bit on output; TRUE if SMRAM > is > > locked. > > @param[out] OpenState Reflects the inverse of the T_EN bit on output; > TRUE > > - iff SMRAM is open. > > + if SMRAM is open. > > **/ > > VOID > > GetStates ( > > diff --git a/OvmfPkg/SmmAccess/SmramInternal.h > b/OvmfPkg/SmmAccess/SmramInternal.h > > index 4e9ac05..4d563d4 100644 > > --- a/OvmfPkg/SmmAccess/SmramInternal.h > > +++ b/OvmfPkg/SmmAccess/SmramInternal.h > > @@ -40,10 +40,10 @@ typedef enum { > > the LockState and OpenState fields being up-to-date on entry, and they > > need > > to restore the same invariant on exit, if they touch the bits in > > question. > > > > - @param[out] LockState Reflects the D_LCK bit on output; TRUE iff SMRAM > is > > + @param[out] LockState Reflects the D_LCK bit on output; TRUE if SMRAM > is > > locked. > > @param[out] OpenState Reflects the inverse of the T_EN bit on output; > TRUE > > - iff SMRAM is open. > > + if SMRAM is open. > > **/ > > VOID > > GetStates ( > > diff --git a/OvmfPkg/VirtioBlkDxe/VirtioBlk.c > b/OvmfPkg/VirtioBlkDxe/VirtioBlk.c > > index f1c3f87..223dcec 100644 > > --- a/OvmfPkg/VirtioBlkDxe/VirtioBlk.c > > +++ b/OvmfPkg/VirtioBlkDxe/VirtioBlk.c > > @@ -135,7 +135,7 @@ VirtioBlkReset ( > > caller is responsible to ensure this > > parameter > > is positive. > > > > - @param[in] RequestIsWrite TRUE iff data transfer goes from guest to > > + @param[in] RequestIsWrite TRUE if data transfer goes from guest to > > device. > > > > > > @@ -219,7 +219,7 @@ VerifyReadWriteRequest ( > > @param[in out] Buffer The guest side area to read data from the > > device > > into, or write data to the device from. > > > > - @param[in] RequestIsWrite TRUE iff data transfer goes from guest to > > + @param[in] RequestIsWrite TRUE if data transfer goes from guest to > > device. > > > > Return values are common to both use cases, and are appropriate to be > > @@ -890,7 +890,7 @@ VirtioBlkExitBoot ( > > > > After we've pronounced support for a specific device in > > DriverBindingSupported(), we start managing said device (passed in by the > > - Driver Exeuction Environment) with the following service. > > + Driver Execution Environment) with the following service. > > > > See DriverBindingSupported() for specification references. > > > > @@ -905,7 +905,7 @@ VirtioBlkExitBoot ( > > > > @retval EFI_SUCCESS Driver instance has been created and > > initialized for the virtio-blk device, it > > - is now accessibla via > > EFI_BLOCK_IO_PROTOCOL. > > + is now accessible via > > EFI_BLOCK_IO_PROTOCOL. > > > > @retval EFI_OUT_OF_RESOURCES Memory allocation failed. > > > > diff --git a/OvmfPkg/VirtioBlkDxe/VirtioBlk.h > b/OvmfPkg/VirtioBlkDxe/VirtioBlk.h > > index ca4b7a0..6c402ca 100644 > > --- a/OvmfPkg/VirtioBlkDxe/VirtioBlk.h > > +++ b/OvmfPkg/VirtioBlkDxe/VirtioBlk.h > > @@ -96,7 +96,7 @@ VirtioBlkDriverBindingSupported ( > > > > After we've pronounced support for a specific device in > > DriverBindingSupported(), we start managing said device (passed in by the > > - Driver Exeuction Environment) with the following service. > > + Driver Execution Environment) with the following service. > > > > See DriverBindingSupported() for specification references. > > > > @@ -111,7 +111,7 @@ VirtioBlkDriverBindingSupported ( > > > > @retval EFI_SUCCESS Driver instance has been created and > > initialized for the virtio-blk device, it > > - is now accessibla via > > EFI_BLOCK_IO_PROTOCOL. > > + is now accessible via > > EFI_BLOCK_IO_PROTOCOL. > > > > @retval EFI_OUT_OF_RESOURCES Memory allocation failed. > > > > diff --git a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c > b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c > > index 25b06fc..1f49cb2 100644 > > --- a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c > > +++ b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c > > @@ -393,7 +393,7 @@ VirtioPciUninit ( > > > > After we've pronounced support for a specific device in > > DriverBindingSupported(), we start managing said device (passed in by the > > - Driver Exeuction Environment) with the following service. > > + Driver Execution Environment) with the following service. > > > > See DriverBindingSupported() for specification references. > > > > diff --git a/OvmfPkg/XenIoPciDxe/XenIoPciDxe.c > b/OvmfPkg/XenIoPciDxe/XenIoPciDxe.c > > index c205cf7..982f3a6 100644 > > --- a/OvmfPkg/XenIoPciDxe/XenIoPciDxe.c > > +++ b/OvmfPkg/XenIoPciDxe/XenIoPciDxe.c > > @@ -123,7 +123,7 @@ XenIoPciDeviceBindingSupported ( > > > > After we've pronounced support for a specific device in > > DriverBindingSupported(), we start managing said device (passed in by the > > - Driver Exeuction Environment) with the following service. > > + Driver Execution Environment) with the following service. > > > > See DriverBindingSupported() for specification references. > > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
