Reviewed-By: Wu Jiaxin <[email protected]> Best Regards! Jiaxin
> -----Original Message----- > From: Zhang, Lubo > Sent: Friday, July 8, 2016 3:51 PM > To: [email protected] > Cc: Fu, Siyuan <[email protected]>; Ye, Ting <[email protected]>; Wu, > Jiaxin <[email protected]> > Subject: [patch] NetworkPkg: Fix Assert issue in iSCSI driver. > > The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS, > since MacString now is a pointer, the value sizeof(MacString)/sizeof > (MacString[0]) is not correct here as the third parameter. > > Cc: Fu Siyuan <[email protected]> > Cc: Ye Ting <[email protected]> > Cc: Wu Jiaxin <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo <[email protected]> > --- > NetworkPkg/IScsiDxe/IScsiConfig.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c > b/NetworkPkg/IScsiDxe/IScsiConfig.c > index 8015e3d..3631e72 100644 > --- a/NetworkPkg/IScsiDxe/IScsiConfig.c > +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c > @@ -685,11 +685,11 @@ IScsiConvertIfrNvDataToAttemptConfigData ( > MacString = (CHAR16 *) AllocateZeroPool (ISCSI_MAX_MAC_STRING_LEN * > sizeof (CHAR16)); > if (MacString == NULL) { > return EFI_OUT_OF_RESOURCES; > } > > - AsciiStrToUnicodeStrS (Attempt->MacString, MacString, sizeof (MacString) > / sizeof (MacString[0])); > + AsciiStrToUnicodeStrS (Attempt->MacString, MacString, > + ISCSI_MAX_MAC_STRING_LEN); > > UnicodeSPrint ( > mPrivate->PortString, > (UINTN) ISCSI_NAME_IFR_MAX_SIZE, > L"MAC: %s, PFA: Bus %d | Dev %d | Func %d, iSCSI mode: %s, IP > version: %s", > -- > 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
