On 07/13/16 22:31, Ard Biesheuvel wrote:
> On 13 July 2016 at 22:17, Laszlo Ersek <[email protected]> wrote:
>> On 07/13/16 22:03, Ard Biesheuvel wrote:
>>> On 13 July 2016 at 18:44, Laszlo Ersek <[email protected]> wrote:
>>>> + DEBUG_CODE (
>>>> + CHAR16 *DevicePathString;
>>>> +
>>>> + DevicePathString =
>>>> ConvertDevicePathToText(BootOptions[Index].FilePath,
>>>> + FALSE, FALSE);
>>>> + DEBUG ((
>>>> + EFI_ERROR (Status) ? EFI_D_WARN : EFI_D_VERBOSE,
>>>> + "%a: removing stale Boot#%04x %s: %r\n",
>>>> + __FUNCTION__,
>>>> + (UINT32)BootOptions[Index].OptionNumber,
>>>> + DevicePathString == NULL ? L"<unavailable>" : DevicePathString,
>>>> + Status
>>>> + ));
>>>> + if (DevicePathString != NULL) {
>>>> + FreePool (DevicePathString);
>>>> + }
>>>> + );
>>>
>>> Indentation?
>>
>> This was intentional on my part; the canonical edk2 style requires
>>
>> BlahBlah (
>> Foo,
>> Bar,
>> Quux
>> );
>>
>> Are you suggesting we shouldn't follow it in this case, with DEBUG_CODE?
>> If so I hope you'd be okay with me fixing up that one trailing ")"
>> before pushing the patch :)
>>
>
> I don't care too deeply, tbh, it is just something that stands out
> when looking at the patch.
>
> So leave it, or change it, as you prefer.
I left it alone, in order to stay close to the original OvmfPkg patch.
> Reviewed-by: Ard Biesheuvel <[email protected]>
Thank you! Pushed as 0e2c6c552990.
Cheers
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
