Laszlo:
   Your patches (total 5) are good to me.  Reviewed-by: Liming Gao 
<[email protected]>

Thanks
Liming
> -----Original Message-----
> From: Laszlo Ersek [mailto:[email protected]]
> Sent: Friday, July 15, 2016 4:14 PM
> To: edk2-devel-01 <[email protected]>
> Cc: Andrew Fish <[email protected]>; Fan, Jeff <[email protected]>; Justen,
> Jordan L <[email protected]>; Gao, Liming <[email protected]>;
> Kinney, Michael D <[email protected]>; Ni, Ruiyu
> <[email protected]>; Zhu, Yonghong <[email protected]>
> Subject: [PATCH 0/5] build fixes
> 
> So I've finally managed to set up VS2015x86 for test-building OVMF.
> Thanks Jordan and Liming for the instructions back in April (IIRC). The
> setup was a total pain, in no small part because there are three
> competing git implementations for Windows (cygwin, msys, and the
> standalone package from the git website (which is what I ultimately ran
> with)).
> 
> With these patches in place, I managed to build OVMF in my preferred
> configurations, for Ia32, Ia32X64, X64, each with GCC44 through GCC49,
> plus gcc-6.1 (using GCC49 settings), plus VS2015x86.
> 
> Cc: Andrew Fish <[email protected]>
> Cc: Jeff Fan <[email protected]>
> Cc: Jordan Justen <[email protected]>
> Cc: Liming Gao <[email protected]>
> Cc: Michael Kinney <[email protected]>
> Cc: Ruiyu Ni <[email protected]>
> Cc: Yonghong Zhu <[email protected]>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (5):
>   MdeModulePkg/PciHostBridgeDxe: fix Ia32 GCC44 build error
>   BaseTools/tools_def.template: bump minimum required NASM versions
>   UefiCpuPkg/PiSmmCpuDxeSmm: remove superfluous ENDs from NASM
> source
>   OvmfPkg/PciHostBridgeLib: silence IA32 VS2015x86 warnings
>   OvmfPkg/PlatformPei: silence X64 VS2015x86 warning
> 
>  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 2 +-
>  OvmfPkg/Library/PciHostBridgeLib/XenSupport.c           | 4 ++--
>  OvmfPkg/PlatformPei/MemDetect.c                         | 2 +-
>  BaseTools/Conf/tools_def.template                       | 4 +++-
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm        | 2 --
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.nasm             | 1 -
>  6 files changed, 7 insertions(+), 8 deletions(-)
> 
> --
> 1.8.3.1

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to