Ard: I understand this patch replaces Steven patch [PATCH v2 4/7] BaseTools-Conf:Introduce GCC5 new toolchain for x86. So, I expect it enables the same functionality in IA32 & X64 to Steven patch.
Thanks Liming -----Original Message----- From: Ard Biesheuvel [mailto:[email protected]] Sent: Monday, July 18, 2016 1:55 PM To: Gao, Liming <[email protected]> Cc: Justen, Jordan L <[email protected]>; [email protected]; [email protected]; Kinney, Michael D <[email protected]>; [email protected] Subject: Re: [edk2] [RFC PATCH] BaseTools GCC: add support for GCC/X64 and GCC/AARCH64 in LTO mode On 18 July 2016 at 07:46, Gao, Liming <[email protected]> wrote: > Ard: > Yes. I will evaluate to add this support in BaseTools instead of adding > shell script or python script. > > Besides, I also request to enable LTO for all ARCHs in new GCC5 tool chain, > at least IA32 and X64. > OK. Do you agree to enable it for both DEBUG and RELEASE (in the IA32 and X64 case)? For ARM, I would like to keep the existing practice of having a DEBUG build that is suitable for single step debugging in GDB, and I am not sure yet how this is supposed to work under LTO, so there I only added it to RELEASE for now. -- Ard. >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf >> Of Ard Biesheuvel >> Sent: Monday, July 18, 2016 1:44 PM >> To: Gao, Liming <[email protected]> >> Cc: Justen, Jordan L <[email protected]>; >> [email protected]; [email protected]; Kinney, Michael D >> <[email protected]>; [email protected] >> Subject: Re: [edk2] [RFC PATCH] BaseTools GCC: add support for >> GCC/X64 and GCC/AARCH64 in LTO mode >> >> On 18 July 2016 at 07:39, Gao, Liming <[email protected]> wrote: >> > Ard: >> > I would like to enable LTO for all ARCHs in new GCC5 tool chain, >> > at least >> IA32 and X64. >> > >> > I like idea to reuse the same build rule. Your patch adds >> > lto-ld-wrapper.sh. >> But, this doesn't work in Windows. As you know, we can build tips >> with GCC in windows OS. >> (https://sourceforge.net/projects/edk2developertoolsforwindows/files) >> . I would still support it. Have we other way to do it? >> > >> >> I mentioned in the commit log that this indeed does not work on >> Windows. I don't use Windows, so I will not be able to test any >> alternatives, but I think there are two solutions possible: >> - use a python script >> - add support to BaseTools to translate a GNU/LD command line to a >> GNU/GCC command line. >> >> In either case, I suppose it would be implemented in python. The only >> difference is how to wire it up, i.e., either add it to tools_def.txt >> (as I have demonstrated), or update the existing build rules for GCC >> to take the script into account in some way. >> >> Regards, >> Ard. >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
